-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign repo list and include last pipeline #4386
Conversation
I would suggest to place the status icon in front of the last pipeline message to group all info that belongs to the pipeline. The time feels a bit far away on the desktop screen, however I've no nice idea were to place it instead. To avoid two icons we could remove the pipeline type icon (push, pr, ...). Some similar UIs I've found: |
Did some rework. What do you think about this approach: |
I like the new layout. Thanks for putting the time and effort in! There's still room for UX improvement, but we can go from there and iterate on it. E.g. I think we have too much free space in the middle now where the repo list starts. Additionally, I don't like the coloring of the "public" badge so much. I know it is already in use like this in the "add repository" list. Personally, I'd prefer no background but only a rounded border with a solid colored text. The gray color doesn't really fit into the light theme well, IMO. But this can also be done in a follow-up PR as this one is mainly about the layout. Another idea would be to add possible repo avatars, now that we have so much space. And deciding for a visually pleasing default image. |
No problem :) also credits to @anbraten for starting the work on it
Spacing is always a bit difficult. Too less and it looks weird, too much is wasting space.
I would like to rework the badges globally, I also don't like them.
We can try again, but for me, it was too much and looked overloaded. |
That's how it looks right now for me on Firefox: Bildschirmaufzeichnung.vom.2024-11-19.14-28-08.mp4 |
A lot has changes, should be re-approved.
just based on the video, an idea poped up: could the transition from hiding and showing be sothed out (e.g. transition animation) - of course you are free to adopt the idea or not |
My opinion remains, changing the layout (hiding/moving/transforming parts of the overall page layout) on keyboard inputs is a bad UX and should be avoided in any case. |
Ok, after playing around with it, I can't find any better solution. The issue on mobile described by @anbraten is valid, and I agree on that. So to get forward, I would say we live with the tradeoff for now. I just added some changes:
I added all changes to a single commit so they can be easily reverted. Let me know if this compromise is acceptable for you. Bildschirmaufzeichnung.vom.2024-11-20.00-47-07.mp4 |
Most users don't use mobile anyway I guess? If so, there will be future efforts to improve it. Thanks to both of you for finding a consensus and getting this improvement shipped 💙 |
Tearing down https://woodpecker-ci-woodpecker-pr-4386.surge.sh |
Is this per user info then, right? Under User 1 I've added some repos. I did not visited that repos under User 2, but they are on top: Can I adjust the number of recently visited repos to be displayed? Can I hide it or disable completely?
But the issue is about repositories list. What is this about? What is the order? Or something else? What visibility is it supposed to be? Currently I have 7 repos. Is there the N+1 problem? It is event worse: 2*N+1. |
Pretty confusing post for me. I try to sort it:
If the "last access" list is not user based, we should look into that.
No, atm it can't be disabled you can of course hide it by custom CSS.
I don't understand this point. What is your problem/question?
Its 1)
It's supposed to be not "Public" so "Private" or "Internal" but we can improve this part if that's what you are asking for. Maybe turning it around and show if a repo is "Private" or "Internal" makes more sense. But I planned to rework the badges anyway, so I'll keep it in mind.
Also, something we should investigate. |
Thanks in advance.
Thanks for answers.
So, it is Wodpecker's visibility, not the Forge.
👍
Just tried to understand what is the "pipeline list" you are talking about? Where it is and how I can test it? |
Oh, now I got it. That's just a typo in the PR description, sorry for the confusion. It was meant to be:
Ill fix it in the PR description |
Yes it shows the woodpecker state of the repo, whatever you have configured for it in the WP repos settings will apply here. |
It's the last 4 visited repos. If you never visited a repo it shows the first 4 repos from the "general" list (probably sorted by last pipeline time). Just noticed the repo list for an org doesn't seem to be sorted by pipeline time. |
Then I have another feedback. Repos list used to be sorted by name, right? So, it was kinda static. One could remember at a subconscious level where some repo is. Like: it is somewhere "one scroll from the top" and then "on the middle of the page". So, after "Repositories" clicked, I do one scroll and move pointer to the center of the screen. Then, I find the repo visually, adjust position of the pointer and click. Now, this list is dynamic, it always changes. I even can do nothing, just hit F5 and there will be completely reordered list, just because my teammates push changes, PRs got merged or some cron jobs. Reminds me of https://www.youtube.com/watch?v=uRGljemfwUE&t=507s 🤣 It would be great to have sorting setting like in GitHub and default is by name. |
Sure, there will always be different use cases and preferences. But IMO, the repo list was quite useless. For me getting this PR done was a huge achievement and makes the repo list a lot more valuable. But I agree, sorting options would be useful. Besides that, I would recommend creating separate issues for all the missing features you discovered. BTW even the GitHub repo list is sorted by last activity by default same for Issues PR's, etc. and in my opinion that should be the default for WP as well even if we add other sort options. |
Maybe. At least it is in Gitea.
Not for me |
Supersedes: #2552
I tried out many variants of what information should be displayed in the repo list with different layouts and decided on the absolute minimum. Everything else seemed kind of overloaded and cluttered (especially as it has to work consistently on mobile). However, if you have any ideas, please let me know, but I would like to keep this PR small and focus on the repo list for now.
Repo list (desktop):
Repo list (mobile):
OrgRepo list (mobile):