fix astring #35
Closed
fix astring #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternative solution: #35 |
Closed
|
Hmmm... Not sure what's wrong. Based on what's on npm this should work 🤔 |
|
Heya! we detected a broken patch in astring yesterday (davidbonnet/astring#505), it was fixed 19 hours ago: davidbonnet/astring@6d8a122. So, And: it was export maps and ESM 😅 |
|
You caught me right before heading out. I’ll take my laptop with me, so do let me know if I need to land a hotfix! |
|
Ah, gotcha. I'll let folks know that |
|
I think the fix in astring makes this PR superfluous, so I’ll close these two. For anyone else stumbling on this, please try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kentcdodds/mdx-bundler#15
Fixes kentcdodds/mdx-bundler#18