refactor: (#515) getter 메서드 명 수정

woowacourse-teams · Sep 7, 2023 · 4007567 · 4007567
1 parent 9eba1d8
commit 4007567
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 20 deletions.
diff --git a/backend/src/main/java/com/votogether/domain/member/service/MemberService.java b/backend/src/main/java/com/votogether/domain/member/service/MemberService.java
@@ -73,11 +73,11 @@ public MemberInfoResponse findMemberInfo(final Member member) {
  public RankingResponse getRanking(final Member member) {
  final RankingBoard rankingBoard = getRankingBoard();
  return new RankingResponse(
- rankingBoard.ranking(member),
+ rankingBoard.getRanking(member),
  member.getNickname(),
- rankingBoard.engagementRecord(member).getPostCount(),
- rankingBoard.engagementRecord(member).getVoteCount(),
- rankingBoard.score(member)
+ rankingBoard.getActivityRecord(member).getPostCount(),
+ rankingBoard.getActivityRecord(member).getVoteCount(),
+ rankingBoard.getScore(member)
  );
  }
 

diff --git a/backend/src/main/java/com/votogether/domain/member/service/RankingBoard.java b/backend/src/main/java/com/votogether/domain/member/service/RankingBoard.java
@@ -38,15 +38,15 @@ private void calculateRank() {
  }
  }
 
- public long score(Member member) {
+ public long getScore(Member member) {
  return passionBoard.get(member).calculateScore();
  }
 
- public int ranking(Member member) {
+ public int getRanking(Member member) {
  return ranking.get(member);
  }
 
- public ActivityRecord engagementRecord(Member member) {
+ public ActivityRecord getActivityRecord(Member member) {
  return passionBoard.get(member);
  }
 

diff --git a/backend/src/test/java/com/votogether/domain/member/entity/RankingBoardTest.java b/backend/src/test/java/com/votogether/domain/member/entity/RankingBoardTest.java
@@ -38,12 +38,12 @@ void calculateRank() {
 
  //when, then
  assertAll(
- () -> assertThat(rankingBoard.score(memberA)).isEqualTo(6),
- () -> assertThat(rankingBoard.score(memberB)).isEqualTo(7),
- () -> assertThat(rankingBoard.score(memberC)).isEqualTo(8),
- () -> assertThat(rankingBoard.ranking(memberA)).isEqualTo(3),
- () -> assertThat(rankingBoard.ranking(memberB)).isEqualTo(2),
- () -> assertThat(rankingBoard.ranking(memberC)).isEqualTo(1)
+ () -> assertThat(rankingBoard.getScore(memberA)).isEqualTo(6),
+ () -> assertThat(rankingBoard.getScore(memberB)).isEqualTo(7),
+ () -> assertThat(rankingBoard.getScore(memberC)).isEqualTo(8),
+ () -> assertThat(rankingBoard.getRanking(memberA)).isEqualTo(3),
+ () -> assertThat(rankingBoard.getRanking(memberB)).isEqualTo(2),
+ () -> assertThat(rankingBoard.getRanking(memberC)).isEqualTo(1)
  );
  }
 
@@ -70,13 +70,13 @@ void calculateRank1() {
 
  //when, then
  assertAll(
- () -> assertThat(rankingBoard.score(memberA)).isEqualTo(6),
- () -> assertThat(rankingBoard.score(memberB)).isEqualTo(8),
- () -> assertThat(rankingBoard.score(memberC)).isEqualTo(8),
- () -> assertThat(rankingBoard.ranking(memberA)).isEqualTo(4),
- () -> assertThat(rankingBoard.ranking(memberB)).isEqualTo(1),
- () -> assertThat(rankingBoard.ranking(memberC)).isEqualTo(1),
- () -> assertThat(rankingBoard.ranking(memberD)).isEqualTo(1)
+ () -> assertThat(rankingBoard.getScore(memberA)).isEqualTo(6),
+ () -> assertThat(rankingBoard.getScore(memberB)).isEqualTo(8),
+ () -> assertThat(rankingBoard.getScore(memberC)).isEqualTo(8),
+ () -> assertThat(rankingBoard.getRanking(memberA)).isEqualTo(4),
+ () -> assertThat(rankingBoard.getRanking(memberB)).isEqualTo(1),
+ () -> assertThat(rankingBoard.getRanking(memberC)).isEqualTo(1),
+ () -> assertThat(rankingBoard.getRanking(memberD)).isEqualTo(1)
  );
  }