Skip to content

Commit

Permalink
[FE] chore: 불필요한 이미지,컴포넌트 삭제 (#692)
Browse files Browse the repository at this point in the history
* chore: 불필요한 홈 캐러셀 이미지 삭제

* chore: 사용하지 않는 이미지 파일 삭제

* chore: 사용하지 않는 컴포넌트 삭제

* chore: 사용하지 않는 컴포넌트 수정 사항 반영

* fix: 리뷰 리스트 목 데이터 아이디 변경

* chore: 리뷰 상세 페이지에서 사용하지 않는 컴포넌트와 코드삭제

* fix: props명 오류 수정
  • Loading branch information
BadaHertz52 authored Sep 26, 2024
1 parent 65abdf3 commit d5c43e9
Show file tree
Hide file tree
Showing 16 changed files with 6 additions and 374 deletions.
10 changes: 0 additions & 10 deletions frontend/src/assets/downArrow.svg

This file was deleted.

3 changes: 0 additions & 3 deletions frontend/src/assets/menu.svg

This file was deleted.

67 changes: 0 additions & 67 deletions frontend/src/assets/usageCarosel1.svg

This file was deleted.

60 changes: 0 additions & 60 deletions frontend/src/assets/usageCarosel2.svg

This file was deleted.

61 changes: 0 additions & 61 deletions frontend/src/assets/usageCarosel3.svg

This file was deleted.

13 changes: 0 additions & 13 deletions frontend/src/components/common/RevieweeComments/index.tsx

This file was deleted.

13 changes: 0 additions & 13 deletions frontend/src/components/common/RevieweeComments/styles.ts

This file was deleted.

1 change: 0 additions & 1 deletion frontend/src/components/common/index.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
export { default as Button } from './Button';
export { default as Input } from './Input';
export { default as ReviewDate } from './ReviewDate';
export { default as RevieweeComments } from './RevieweeComments';
export { default as MultilineTextViewer } from './MultilineTextViewer';
export { default as TopButton } from './TopButton';
export { default as Checkbox } from './Checkbox';
Expand Down
24 changes: 0 additions & 24 deletions frontend/src/components/common/modals/SideModal/index.tsx

This file was deleted.

12 changes: 0 additions & 12 deletions frontend/src/components/common/modals/SideModal/styles.ts

This file was deleted.

1 change: 0 additions & 1 deletion frontend/src/components/common/modals/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
export { default as SideModal } from './SideModal';
export { default as ConfirmModal } from './ConfirmModal';
export { default as AlertModal } from './AlertModal';
export { default as ErrorAlertModal } from './ErrorAlertModal';
2 changes: 1 addition & 1 deletion frontend/src/mocks/mockData/reviewListMockData.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export const REVIEW_LIST: ReviewList = {
lastReviewId: 12,
reviews: [
{
reviewId: 1,
reviewId: 5,
createdAt: '2024-07-24',
contentPreview: `1. 물론 시중에 출간되어 있는 책들로 공부하는 것도 큰 장점이지만 더 깊은 공부를 하고 싶을 때 공식 문서를 확인해보는 것이 좋기 때문에, 저 개인적인 생각으로는 언어 공부를 아예 처음 입문하시는 분들은 한국에서 출간된 개발 서적으로 공부를 시작하시다가 모르는 부분이.....`,
categories: [
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,33 +1,20 @@
import { ReviewDate } from '@/components';
import { ProjectImgProps } from '@/components/common/ProjectImg';
import { ReviewDateProps } from '@/components/common/ReviewDate';

// import LockToggle from '../LockToggle';
import ReviewDate, { ReviewDateProps } from '@/components/common/ReviewDate';

import * as S from './styles';

// const PROJECT_IMAGE_SIZE = '6rem';
const DATE_TITLE = '리뷰 작성일';

interface ReviewDescriptionProps extends Omit<ProjectImgProps, '$size'>, Omit<ReviewDateProps, 'dateTitle'> {
interface ReviewDescriptionProps extends Omit<ReviewDateProps, 'dateTitle'> {
projectName: string;
isPublic: boolean;
revieweeName: string;
handleClickToggleButton: () => void;
}

const ReviewDescription = ({
// thumbnailUrl,
projectName,
revieweeName,
// isPublic,
date,
// handleClickToggleButton,
}: ReviewDescriptionProps) => {
const ReviewDescription = ({ projectName, revieweeName, date }: ReviewDescriptionProps) => {
return (
<S.Description>
<S.DescriptionSide>
{/* NOTE: 추후에 깃허브 로고 대신 다른 이미지로 대체될 수 있어서 일단 주석 처리 */}
{/* <ProjectImg thumbnailUrl={thumbnailUrl} projectName={projectName} $size={PROJECT_IMAGE_SIZE} /> */}
<S.ProjectInfoContainer>
<S.ProjectName>{projectName}</S.ProjectName>
<S.RevieweeNameAndDateContainer>
Expand All @@ -38,9 +25,6 @@ const ReviewDescription = ({
</S.RevieweeNameAndDateContainer>
</S.ProjectInfoContainer>
</S.DescriptionSide>
{/* 시현 때 숨김 <S.DescriptionSide>
<LockToggle $isPublic={isPublic} handleClickToggleButton={handleClickToggleButton} />
</S.DescriptionSide> */}
</S.Description>
);
};
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/ErrorPage/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const ErrorPage = () => {

return (
<PageLayout isNeedBreadCrumb={false}>
<ErrorSection errorMessage={ROUTE_ERROR_MESSAGE} handleReload={handleReload} handleGoHome={handleGoHome} />
<ErrorSection errorMessage={ROUTE_ERROR_MESSAGE} handleReload={handleReload} handleGoOtherPage={handleGoHome} />
</PageLayout>
);
};
Expand Down

0 comments on commit d5c43e9

Please sign in to comment.