[FE] chore: 불필요한 이미지,컴포넌트 삭제 #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImxYJL
approved these changes
Sep 25, 2024
soosoo22
approved these changes
Sep 26, 2024
BadaHertz52
changed the title
chysis
requested changes
Sep 26, 2024
| import { useGroupAccessCode } from '@/hooks'; | ||
|
|
||
| import { DetailedReviewPageContents } from './components'; | ||
|
|
||
| const DetailedReviewPage = () => { | ||
| const { groupAccessCode } = useGroupAccessCode(); | ||
|
|
||
| if (!groupAccessCode) return <LoginRedirectModal />; | ||
| if (!groupAccessCode) return; |
There was a problem hiding this comment.
undefined를 반환하지 않고, null을 명시적으로 반환하도록 하는 것이 좋을 것 같아요.
Suggested change
| if (!groupAccessCode) return; | |
| if (!groupAccessCode) return null; |
There was a problem hiding this comment.
해당 부분은 쿠키 적용한 리뷰 상세페이지 pr이 있어서 해당 pr 머지 후 pull 받을 거라 임시로 고쳤어요
| @@ -32,12 +32,10 @@ const ReviewListPage = () => { | |||
|
|
|||
| return ( | |||
| <> | |||
| {groupAccessCode && storedReviewRequestCode ? ( | |||
| {groupAccessCode && storedReviewRequestCode && ( | |||
There was a problem hiding this comment.
추후에 조건문 부분을 변수로 빼도 좋을 것 같네요
There was a problem hiding this comment.
해당 부분은 목록 페이에 쿠키가 적용된 pr에 올라가 있어서, 해당 pr 머지 후 pull 받을 거라 임시로 고쳤어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
📚 참고 자료, 할 말