Suggestions for #114 #117
Merged
Suggestions for #114 #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
changed the base branch from
trunk
to
feat/host-provides-editor-settings
dcalhoun
approved these changes
Apr 16, 2025
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
I like the changes; solid improvements. Thank you for taking time to open a PR.
Member
|
Also noting: I smoke tested both the bundled and site-specific editors—I did not encounter any issues. |
dcalhoun
added a commit
that referenced
this pull request
Apr 24, 2025
* feat: Limit block types to an allowed list To improve stability, the remote, site-specific editor un-registers block types that are not on the allow list. * fix: Seed GBKit global from local storage This is largely in place for development experience purposes, not user facing. It allows the editor WebView to reload and retains its current GBKit global. * fix: Guard against undefined allowed block types configuration Avoid exceptions invoking array methods on `undefined`. * Revert "fix: Seed GBKit global from local storage" This reverts commit 38fe2c7. * hoist settings * feat: Expose bridge method for updating editor settings * Revert "feat: Expose bridge method for updating editor settings" This reverts commit 2e1f1464ac65899dc3a5b23af12b59978a34dee9. * feat: Improve editor start sequence * refactor: Separate warm up mode load behaviour To allow the host app to manage editor start sequence, we do not start within `viewDidLoad`. * refactor: Remote editor relies upon host app settings * refactor: Android receives editor settings from host app Hoist editor settings fetching and configuration to the host app to allow more control of the editor initialization flow. * refactor: Pass Android editor settings as JSON string Avoid difficulties typing complex JSON structures. * refactor: Clean up logic Remove unnecessary or unused code. * task: Capture build output * task: Capture build output * Make `isWarmupMode` immutable (#117) --------- Co-authored-by: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I had a suggestion for #114 that was longer than would make sense in the suggestions box
Why?
Prevents invalid states in the editor view controller
How?
Testing Instructions
Accessibility Testing Instructions
Screenshots or screencast