Skip to content

Suggestions for #114 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcalhoun merged 1 commit into from
Apr 16, 2025
Merged

Suggestions for #114 #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ios/Sources/GutenbergKit/Sources/EditorConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ public struct EditorConfiguration {
public mutating func updateEditorSettings(_ settings: [String: Any]?) {
self.editorSettings = settings
}

public static let `default` = EditorConfiguration()
}

public struct WebViewGlobal {
Expand Down
16 changes: 12 additions & 4 deletions ios/Sources/GutenbergKit/Sources/EditorViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,17 @@ public final class EditorViewController: UIViewController, GutenbergEditorContro
public var editorURL: URL?

private var cancellables: [AnyCancellable] = []
private var isWarmupMode = false

/// Warmup mode preloads resources into memory to make the UI transition seamless when displaying the editor for the first time
///
private let isWarmupMode: Bool

/// Initalizes the editor with the initial content (Gutenberg).
public init(configuration: EditorConfiguration = .init()) {
public convenience init(configuration: EditorConfiguration = .default) {
self.init(configuration: configuration, isWarmupMode: false)
}

init(configuration: EditorConfiguration = .default, isWarmupMode: Bool = false) {
self.configuration = configuration
self.controller = GutenbergEditorController(configuration: configuration)

Expand All @@ -43,6 +50,8 @@ public final class EditorViewController: UIViewController, GutenbergEditorContro
self.webView = GBWebView(frame: .zero, configuration: config)
self.webView.scrollView.keyboardDismissMode = .interactive

self.isWarmupMode = isWarmupMode

super.init(nibName: nil, bundle: nil)
}

Expand Down Expand Up @@ -330,8 +339,7 @@ public final class EditorViewController: UIViewController, GutenbergEditorContro
/// Calls this at any moment before showing the actual editor. The warmup
/// shaves a couple of hundred milliseconds off the first load.
public static func warmup() {
let editorViewController = EditorViewController()
editorViewController.isWarmupMode = true
let editorViewController = EditorViewController(isWarmupMode: true)
_ = editorViewController.view // Trigger viewDidLoad

// Retain for 5 seconds and let it prefetch stuff
Expand Down