feat: Send modal dialog state to host app #186
+234
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the host to respond to the opening and closing of modal dialogs. This is important for disabling surround interactive native UI elements.
dcalhoun
changed the base branch from
trunk
to
feat/update-android-demo-app-navigation
Avoid user confusion when attempting to dismiss dialog with hardward back button.
Users expect Android's hardware back button controls editor UI popovers.
dcalhoun
changed the title
Address build warning: ``` Conformance of '_EditorView.Coordinator' to protocol 'EditorViewControllerDelegate' crosses into main actor-isolated code and can cause data races; this is an error in the Swift 6 language mode ```
dcalhoun
commented
Oct 6, 2025
| import Foundation | ||
|
|
||
| #if canImport(UIKit) | ||
| @MainActor |
There was a problem hiding this comment.
Added in bd8f3c0 to address conformance warning.
adalpari
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
LGTM! Tested here: wordpress-mobile/WordPress-Android#22260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Send web modal dialog state to the host app.
Why?
Close CMM-822. Close CMM-444. Close #129.
Enable host apps to respond to a web modal dialog opening or closing. E.g., it
may be prudent to disable surrounding native UI while a web modal dialog is
open.
How?
Add bridge events for opening and closing modal dialogs.
Testing Instructions
Important
When testing the iOS Demo app, you may need to run
make buildor use the development server before running the Demo app.1. Web modal dialogs disable native header navigation
2. Android hardware back button dismisses web dialogs
Accessibility Testing Instructions
Perform the testing via a screen reader.
Screenshots or screencast
N/A