feat: Disable header navigation when GutenbergKit opens dialogs #22260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling the native header navigation respects GutenbergKit's web-based modal dialogs, where focus should remain on the dialog to mitigate confusion from surrounding UI elements. The hardware back button now dismisses GutenbergKit dialogs first, before performing the default Android action.
dcalhoun
added
[Type] Enhancement
Posting/Editing
Gutenberg
Project dependencies changeslist! Upgraded Dependencies
org.wordpress.gutenbergkit:android:v0.9.0, (changed from v0.8.1)tree +--- project :libs:editor
-| \--- org.wordpress.gutenbergkit:android:v0.8.1
+| \--- org.wordpress.gutenbergkit:android:v0.9.0
-\--- org.wordpress.gutenbergkit:android:v0.8.1 (*)
+\--- org.wordpress.gutenbergkit:android:v0.9.0 (*) |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22260-0665462 | |
| Commit | 0665462 | |
| Direct Download | wordpress-prototype-build-pr22260-0665462.apk |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WordPress/src/main/java/org/wordpress/android/ui/posts/GutenbergKitActivity.kt
Fixed
Show fixed
Hide fixed
WordPress/src/main/java/org/wordpress/android/ui/posts/GutenbergKitActivity.kt
Fixed
Show fixed
Hide fixed
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22260-0665462 | |
| Commit | 0665462 | |
| Direct Download | jetpack-prototype-build-pr22260-0665462.apk |
adalpari
approved these changes
Oct 7, 2025
Communicate the disabled state visually.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close CMM-824. Ref CMM-444. Ref wordpress-mobile/GutenbergKit#129.
Integrates wordpress-mobile/GutenbergKit#186.
Disabling the native header navigation respects GutenbergKit's web-based
modal dialogs, where focus should remain on the dialog to mitigate
confusion from surrounding UI elements.
The hardware back button now dismisses GutenbergKit dialogs first,
before performing the default Android action.
Testing instructions
1. Web modal dialogs disable native header navigation
2. Android hardware back button dismisses web dialogs