refactor: Improve build configuration #2
Conversation
dcalhoun
commented
Jul 10, 2024
dcalhoun
commented
- Set a project Node.js version mirroring the Gutenberg project to avoid version conflicts.
- Enable web view inspection to improve debugging.
- Add effect clean up to avoid block registration errors.
Avoid unexpected version issues.
Improve debugging.
React strict mode double runs effects, which led to numerous errors like the following: ``` [Error] Block "core/paragraph" is already registered. ```
There was a problem hiding this comment.
This repo was originally intended to be a throw-away prototype—especially the CSS code—but there is probably some value in keeping it. The Swift package, the WKWebView management code, and the Vite setup aren't so bad.
I'm going to move this to the wordpress-mobile organization.
The PR looks good, except for one comment I left.
| webView.alpha = 0 | ||
|
|
||
| if #available(iOS 16.4, *) { | ||
| webView.isInspectable = true |
There was a problem hiding this comment.
I'm not sure what's the implication of making a web view inspectable, but I decided to keep it off by default. The app enables it in the debug mode.
There was a problem hiding this comment.
I interpet "debug mode" to mean the scheme configuration for running the app. I have that enabled, but the web view does not display as inspectable for me in Safari. Am I missing something?
| Xcode Scheme | Safari Inspector |
|---|---|
 |
 |
There was a problem hiding this comment.
Ah, I forgot I only enabled it in the jpios/wpios apps but not in this demo. I suggest enabling it in the demo project instead of the package itself.
There was a problem hiding this comment.
I moved this to the Demo if you don't mind – merging.
Make sense. I still consider it throw away as well, but figured continued explorations were worth sharing in a central location. |
2 participants
