Skip to content

refactor: Improve build configuration #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kean merged 3 commits into from
Jul 10, 2024
Merged

refactor: Improve build configuration #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2622ed
build: Configure project Node.js version
dcalhoun Jul 9, 2024
b56eb50
build: Enable WebView inspection
dcalhoun Jul 10, 2024
ec07c3a
fix: Avoid React strict mode errors
dcalhoun Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20
8 changes: 8 additions & 0 deletions ReactApp/src/components/Editor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
ObserveTyping,
} from '@wordpress/block-editor';
import { Popover } from '@wordpress/components';
import { getBlockTypes, unregisterBlockType } from '@wordpress/blocks';
import { registerCoreBlocks } from '@wordpress/block-library';
import { parse, serialize, registerBlockType } from '@wordpress/blocks';

Expand Down Expand Up @@ -75,6 +76,13 @@ function Editor() {
window.editor = editor;
registerCoreBlocks();
postMessage("onEditorLoaded");

return () => {
window.editor = {};
getBlockTypes().forEach((block) => {
unregisterBlockType(block.name);
});
};
}, []);

const settings = {
Expand Down
4 changes: 4 additions & 0 deletions Sources/GutenbergKit/Sources/EditorViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ public final class EditorViewController: UIViewController, GutenbergEditorContro
])

webView.alpha = 0

if #available(iOS 16.4, *) {
webView.isInspectable = true
Copy link
Contributor

@kean kean Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's the implication of making a web view inspectable, but I decided to keep it off by default. The app enables it in the debug mode.

Copy link
Member Author

@dcalhoun dcalhoun Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I interpet "debug mode" to mean the scheme configuration for running the app. I have that enabled, but the web view does not display as inspectable for me in Safari. Am I missing something?

Xcode Scheme Safari Inspector
run-with-debug no-inspectable-applications

Copy link
Contributor

@kean kean Jul 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I forgot I only enabled it in the jpios/wpios apps but not in this demo. I suggest enabling it in the demo project instead of the package itself.

Copy link
Contributor

@kean kean Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this to the Demo if you don't mind – merging.

}

// TODO: register it when editor is loaded
// service.$rawBlockTypesResponseData.compactMap({ $0 }).sink { [weak self] data in
Expand Down