Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gutenberg] Use tarball instead of git tag for forked dependencies #15362

Merged
merged 6 commits into from
Sep 28, 2021
Merged

[Gutenberg] Use tarball instead of git tag for forked dependencies #15362

merged 6 commits into from
Sep 28, 2021

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Sep 20, 2021 •
edited by fluiddot
Loading

Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#3982

This PR only bumps the Gutenberg Mobile reference.

To test:
Follow testing instructions from WordPress/gutenberg#34886.

Regression Notes

  1. Potential unintended areas of impact
    None apart from the editor.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Smoke testing that the editor could be opened and blocks could be added.

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 20, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ceyhun ceyhun mentioned this pull request Sep 20, 2021
Merged
2 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 20, 2021 •
edited
Loading

You can test the changes on this Pull Request by downloading the APKs:

@fluiddot fluiddot mentioned this pull request Sep 24, 2021
Merged
7 tasks
@fluiddot fluiddot marked this pull request as ready for review September 27, 2021 12:23
@fluiddot fluiddot self-assigned this Sep 27, 2021
@fluiddot fluiddot added this to the 18.4 milestone Sep 27, 2021
hypest
hypest approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and runs fine so, I'll go ahead and give it a LGTM!

hypest
hypest approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

And similar to the same comment on the WPiOS PR, before merging the main apps PRs, we shall create an alpha tag to point to the gutenberg-mobile merged version, right?

@fluiddot
Copy link
Contributor

LGTM!

And similar to the same comment on the WPiOS PR, before merging the main apps PRs, we shall create an alpha tag to point to the gutenberg-mobile merged version, right?

Exactly, we'll create an alpha tag after merging the gutenberg-mobile PR and update the reference here.

@fluiddot
Copy link
Contributor

LGTM!
And similar to the same comment on the WPiOS PR, before merging the main apps PRs, we shall create an alpha tag to point to the gutenberg-mobile merged version, right?

Exactly, we'll create an alpha tag after merging the gutenberg-mobile PR and update the reference here.

The Gutenberg Mobile reference now points to the tag v1.63.0-alpha1.

@fluiddot fluiddot merged commit a5d3328 into develop Sep 28, 2021
@fluiddot fluiddot deleted the rnmobile/try-tarball-for-forks branch September 28, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest hypest approved these changes

Assignees

@fluiddot fluiddot

Labels
None yet
Projects
None yet
Milestone
18.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ceyhun @fluiddot @hypest