-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] Use tarball instead of git tag for forked dependencies #17198
Conversation
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Podfile.lock
Outdated
@@ -62,7 +62,7 @@ PODS: | |||
- AppAuth/Core (~> 1.4) | |||
- GTMSessionFetcher/Core (~> 1.5) | |||
- GTMSessionFetcher/Core (1.6.1) | |||
- Gutenberg (1.62.0): | |||
- Gutenberg (1.61.1): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT about updating from develop(s) @fluiddot ? Looks like the tag here is older than the one on develop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll update it, besides, there's a file conflict that should be resolved 👍 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the branch with develop
in this commit.
# Conflicts: # Podfile.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Before merging the main apps PRs, we shall create an alpha tag to point to the gutenberg-mobile merged version, right?
Exactly, we'll create an alpha tag after merging the gutenberg-mobile PR and update the reference here. |
The Gutenberg Mobile reference now points to the tag |
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#3982
This PR only bumps the Gutenberg Mobile reference.
To test:
Follow testing instructions from WordPress/gutenberg#34886.
Regression Notes
Potential unintended areas of impact
None apart from the editor.
What I did to test those areas of impact (or what existing automated tests I relied on)
Smoke testing that the editor could be opened and blocks could be added.
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.