Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Use tarball instead of git tag for forked dependencies #17198

Merged
merged 6 commits into from
Sep 28, 2021

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Sep 20, 2021

Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#3982

This PR only bumps the Gutenberg Mobile reference.

To test:
Follow testing instructions from WordPress/gutenberg#34886.

Regression Notes

  1. Potential unintended areas of impact
    None apart from the editor.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Smoke testing that the editor could be opened and blocks could be added.

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 20, 2021

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 57286. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@ceyhun ceyhun added the Gutenberg Editing and display of Gutenberg blocks. label Sep 20, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 20, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@fluiddot fluiddot self-assigned this Sep 27, 2021
@fluiddot fluiddot added this to the 18.4 milestone Sep 27, 2021
@fluiddot fluiddot marked this pull request as ready for review September 27, 2021 12:23
Podfile.lock Outdated
@@ -62,7 +62,7 @@ PODS:
- AppAuth/Core (~> 1.4)
- GTMSessionFetcher/Core (~> 1.5)
- GTMSessionFetcher/Core (1.6.1)
- Gutenberg (1.62.0):
- Gutenberg (1.61.1):
Copy link
Contributor

@hypest hypest Sep 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about updating from develop(s) @fluiddot ? Looks like the tag here is older than the one on develop.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll update it, besides, there's a file conflict that should be resolved 👍 .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the branch with develop in this commit.

Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Before merging the main apps PRs, we shall create an alpha tag to point to the gutenberg-mobile merged version, right?

@fluiddot
Copy link
Contributor

LGTM!

Before merging the main apps PRs, we shall create an alpha tag to point to the gutenberg-mobile merged version, right?

Exactly, we'll create an alpha tag after merging the gutenberg-mobile PR and update the reference here.

@fluiddot
Copy link
Contributor

LGTM!
Before merging the main apps PRs, we shall create an alpha tag to point to the gutenberg-mobile merged version, right?

Exactly, we'll create an alpha tag after merging the gutenberg-mobile PR and update the reference here.

The Gutenberg Mobile reference now points to the tag v1.63.0-alpha1.

@fluiddot fluiddot merged commit 8344c02 into develop Sep 28, 2021
@fluiddot fluiddot deleted the rnmobile/try-tarball-for-forks branch September 28, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants