-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reader screen for unified prologue carousel #16185
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @frosty , I left one code comment and found a few layout issues:
tags are not very visible in dark mode, looks like the background color did not switch:
on some devices, the vertical alignment is too high or too low (see examples). We might consider positioning the container view in UnifiedProloguePages
relative to the screen size. I tried something like this in #16187
iPad Pro 9.7 iOS 13.5 | iPhone SE 2nd gen iOS 14.4 |
---|---|
![]() |
![]() |
|
||
/// A view modifier that applies style to a text to make it look like a tag token. | ||
/// | ||
private struct TagItem: ViewModifier { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@Gio2018 I've fixed the dark mode issue, but let's tackle the spacing of all the views altogether in a future PR. |
…ture/swiftui-reader-prologue-screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great in dark mode.
A few optional minor adjustments to the icons might be made based on the designs, and yes let's address the positioning separately.
Ref #15056. This PR adds the Reader screen to the prologue carousel.
To test
PR submission checklist:
RELEASE-NOTES.txt
if necessary.