Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Update gesture handler and reanimated libraries #18065

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 2, 2022

Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4615

This PR updates the Gutenberg Mobile reference to add newer versions of the following libraries, which are native dependencies of Gutenberg:

  • react-native-gesture-handler
  • react-native-reanimated

NOTE 1: This PR will be merged into gutenberg/1.72.0-changes branch instead of trunk due we don't know on which Gutenberg Mobile release will be incorporated, therefore all native changes should be put on hold until the next release is planned.

NOTE 2: This PR also includes the changes from #17844 (Autocorrected Headings no longer apply bold formatting if they weren't already bold).

To test:
Follow testing instructions from WordPress/gutenberg#39098.

Regression Notes

  1. Potential unintended areas of impact
    It should only impact the editor hence, I don't foresee any potential unintended areas of impact.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the Gutenberg Editing and display of Gutenberg blocks. label Mar 2, 2022
@fluiddot fluiddot self-assigned this Mar 2, 2022
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 2, 2022

You can test the Jetpack changes on this Pull Request by downloading it from AppCenter here with build number: pr18065-04933d0. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 2, 2022

You can test the WordPress changes on this Pull Request by downloading it from AppCenter here with build number: pr18065-04933d0. IPA is available here. If you need access to this, you can ask a maintainer to add you.

Podfile Show resolved Hide resolved
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 2, 2022

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

RELEASE-NOTES.txt Outdated Show resolved Hide resolved
Co-authored-by: Tanner Stokes <tanner.stokes@automattic.com>
@fluiddot fluiddot marked this pull request as ready for review March 2, 2022 16:39
@fluiddot fluiddot requested a review from geriux March 2, 2022 16:39
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work 👏

@fluiddot fluiddot merged commit 11ab313 into gutenberg/1.72.0-changes Mar 14, 2022
@fluiddot fluiddot deleted the gutenberg/drag-and-drop/update-gesture-and-animation-deps branch March 14, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants