[RNMobile] Update gesture handler and reanimated libraries #39098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hermes engine has to be manually set because the library is not able to detect it automatically.
…g the Gutenberg class from NSObject to UIResponder
The downgrade is necessary in order to prevent a known issue in Reanimated (software-mansion/react-native-reanimated#2719).
Using the absolute path is required for Reanimated plugin when generating the JS bundle outside Gutenberg, like we do in Gutenberg Mobile.
This is required to support the react-native-gesture-handler package.
fluiddot
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
fluiddot
added
the
Mobile App - Automation
2 tasks
fluiddot
removed
the
Mobile App - Automation
|
The unit tests are failing because the new version of This is produced by the React Navigation library, as it still uses the old APIs but since it's just a warning, we should proceed to ignore it. However, in the tests, we can't silence it by using |
fluiddot
commented
Mar 1, 2022
Comment on lines
+22
to
+25
| path.resolve( | ||
| __dirname, | ||
| '../../node_modules/react-native-reanimated/plugin' | ||
| ), |
There was a problem hiding this comment.
The installation instructions from the Reanimated library (reference) specify to use include here:
'react-native-reanimated/plugin',
However, that approach doesn't work when this configuration is referenced from a different location, as we do in GB-mobile (reference). For this reason, I had to reference the plugin by resolving its path.
Comment on lines
-231
to
+234
| - react-native-video (5.0.2-wp-2): | ||
| - react-native-video (5.2.0-wp-2): | ||
| - React-Core | ||
| - react-native-video/Video (= 5.0.2-wp-2) | ||
| - react-native-video/Video (5.0.2-wp-2): | ||
| - react-native-video/Video (= 5.2.0-wp-2) | ||
| - react-native-video/Video (5.2.0-wp-2): |
There was a problem hiding this comment.
Looks like react-native-video was recently updated (reference) but this file wasn't updated to reflect the change.
geriux
approved these changes
Mar 2, 2022
Merged
4 tasks
…nimation-deps # Conflicts: # packages/react-native-editor/ios/Podfile.lock
|
Heads up that I've bumped |
fluiddot
deleted the
rnmobile/drag-and-drop/update-gesture-and-animation-deps
branch
This was referenced Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4615
Description
This PR updates the following libraries:
react-native-gesture-handlerto version2.2.0(forked repository PR)react-native-reanimatedto version2.2.4(forked repository PR)Additionally, due to API changes in the newer versions of both libraries, a set of modifications have been applied.
Testing Instructions
Test example
Click here to display the patch diff
Unit tests pass
npm run native testand observe that all tests pass.Unit Tests / Mobilepass.Screenshots
N/A
Types of changes
Dependencies update
Checklist:
*.native.jsfiles for terms that need renaming or removal).