Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide Gutenberg editor network connection status #22112

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Nov 28, 2023

Note

This also incorporates WordPress/gutenberg#57028 which resolves a rich text editor regression causing failing E2E tests that blocked merging this PR.

Related

Description

Enable the block editor to request and respond to changes to the network
connection status within the host app.

To test: Smoke test the editor, verify it does not crash.

Regression Notes

  1. Potential unintended areas of impact
    The bridge changes could cause the editor to fail to load.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Smoke tested the editor.
  3. What automated tests I added (or what prevented me from doing so)
    None. There is no existing test files for the bridge module. Historically,
    we focus tests on the JavaScript counterparts in Gutenberg.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 28, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22112-9b61a49
Version23.8
Bundle IDorg.wordpress.alpha
Commit9b61a49
App Center BuildWPiOS - One-Offs #8136
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 28, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22112-9b61a49
Version23.8
Bundle IDcom.jetpack.alpha
Commit9b61a49
App Center Buildjetpack-installable-builds #7156
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was able to test successfully via WordPress/gutenberg#56609 (review). 🚀

Enable the block editor to request and respond to changes to the network
connection status within the host app.
@dcalhoun dcalhoun force-pushed the feat/gutenberg-network-status branch from 80cd757 to 84b3b4a Compare December 12, 2023 02:27
@dcalhoun dcalhoun enabled auto-merge December 12, 2023 02:27
@dcalhoun
Copy link
Member Author

This will be incorporated in #22112 as it includes required bridge methods whose absence will cause CI failures.

@dcalhoun dcalhoun closed this Dec 14, 2023
auto-merge was automatically disabled December 14, 2023 16:41

Pull request was closed

@dcalhoun dcalhoun reopened this Dec 14, 2023
@dcalhoun dcalhoun enabled auto-merge December 14, 2023 17:05
@dcalhoun dcalhoun merged commit c4c5b52 into trunk Dec 14, 2023
23 checks passed
@dcalhoun dcalhoun deleted the feat/gutenberg-network-status branch December 14, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants