-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provide Gutenberg editor network connection status #22112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
Gutenberg
Editing and display of Gutenberg blocks.
[Type] Enhancement
labels
Nov 28, 2023
This was referenced Nov 28, 2023
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
Merged
12 tasks
derekblank
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I was able to test successfully via WordPress/gutenberg#56609 (review). 🚀
Enable the block editor to request and respond to changes to the network connection status within the host app.
dcalhoun
force-pushed
the
feat/gutenberg-network-status
branch
from
December 12, 2023 02:27
80cd757
to
84b3b4a
Compare
This will be incorporated in #22112 as it includes required bridge methods whose absence will cause CI failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This also incorporates WordPress/gutenberg#57028 which resolves a rich text editor regression causing failing E2E tests that blocked merging this PR.
Related
Description
Enable the block editor to request and respond to changes to the network
connection status within the host app.
To test: Smoke test the editor, verify it does not crash.
Regression Notes
The bridge changes could cause the editor to fail to load.
Smoke tested the editor.
None. There is no existing test files for the bridge module. Historically,
we focus tests on the JavaScript counterparts in Gutenberg.
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: