-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gallery size labels #1798
Merged
Merged
Fix gallery size labels #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2020
mkevins
force-pushed
the
fix/gallery-size-labels
branch
from
January 23, 2020 01:05
bdc663a
to
106e02c
Compare
chipsnyder
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Wordpress iOS and Wordpress Android working as expected
geriux
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by WordPress/gutenberg#19800 (review)
2 tasks
This was referenced Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1792
Related PR
gutenberg
: WordPress/gutenberg#19800Description
This PR fixes the image size option labels in the gallery block settings. The image size options were added for web, but on mobile, the labels were undefined. This resulted in "blank" buttons, and in the beta build for iOS this also resulted in a crash.
How has this been tested?
Tested on Android via WordPress-Android, and iOS via WordPress-iOS:
Steps:
Expected result:
Steps:
Expected result:
The image resolution should change (to a lower quality with thumbnail, higher quality with large or full).
Screenshots
Types of changes
On mobile, the
name
property in imageSizes is undefined, butlabel
is already set. So this PR defaults to using thelabel
if it is truthy, and falls back to using thename
if not.PR submission checklist:
RELEASE-NOTES.txt
if necessary.