Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.23.0 Release -> Master #1924

Merged
merged 98 commits into from
Feb 21, 2020
Merged

1.23.0 Release -> Master #1924

merged 98 commits into from
Feb 21, 2020

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Feb 17, 2020 •
edited
Loading

Release for Gutenberg Mobile v1.23.0

Related PRs

WPAndroid: wordpress-mobile/WordPress-Android#11331
WPiOS: wordpress-mobile/WordPress-iOS#13485

FluxC-Android: N/A
Aztec-Android: N/A
Aztec-iOS: N/A

Gutenberg: TBD
WPiOS after: TBD
WPAndroid after: TBD

Other repos: No changes in other repos
Merge to gutenberg-mobile master to develop: TBD

Extra PRs that Landed After the Release Was Cut

#1894 Fix inserter
#1930 Make sure strong tags are removed from title
#1938 Fix alignment issues on iOS

Changes

Gathered via git log v1.22.0..release/1.23.0 --first-parent --oneline and trimmed based on whether the change is functional.

PR Submission Checklist

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

mkevins and others added 30 commits January 23, 2020 11:01
@mkevins
Update gutenberg reference
106e02c
@mkevins
Update release notes
8bea249
Update Gutenberg ref
03f051e
Update Gutenberg ref
6e070ec
@mkevins
Update gutenberg reference
c818a52
@mkevins
Merge branch 'develop' into fix/gallery-size-labels
8a63fca
@mkevins
Update gutenberg reference
4a28360
@mkevins
Merge branch 'develop' into fix/gallery-size-labels
e4d6a3b
Merge branch 'develop' of github.com:wordpress-mobile/gutenberg-mobil…
91d817e 
…e into add/stepper-gallery-settings

# Conflicts:
#	gutenberg
Update Gutenberg ref
7836373
Update Gutenberg ref
3e4fdc1
Update Gutenberg ref
2017526
@mkevins
Update gutenberg reference
b1be15b
@mkevins
Merge pull request #1798 from wordpress-mobile/fix/gallery-size-labels
58f4554 
Fix gallery size labels
@jbinda @lukewalczak
Fix: Adjust vertical margins in InnerBlock (#1838)
79c17ca 
* update ref

* Update ref

* update ref

* update ref

* update ref

* update ref to master (adjust vertical margins)

* update ref

Co-authored-by: Luke Walczak <lukasz.walczak.pwr@gmail.com>
@mkevins
Update gutenberg reference
c4ed859
@mkevins
Generate bundles
42e0096
@SergioEstevao
Update Aztec pod to version 1.16.0
3530be8
@SergioEstevao
Remove overriding of metrics for list text indentation.
1d9305a
@jbinda
Feat: Open Group block for production (#1850)
e40988d 
* update ref to master (open group block for production)
@lukewalczak
Button Block (#1616)
3a22f08 
* Add ref to gutenberg repo

* Update ref and add react-native-linear-gradient lib

* Update android in gutenberg-bridge

* Add react-native-linear-gradient podspec

* Update .flowconfig

* Regenerate yarn.lock

* add min and max width for iOS aztec

* Use linear gradient lib from fork

* Fix iOS

* Use linear gradient lib from gb-mobile fork

* Revert changes in initial html

* Use sizeThatFits instead of introduced new function

* Update ref and add color

* Generate bundles for testing purposes

* Generate fresh bundle

* Remove bundle

* Revert bundle changes

* Revert bundles

* Update ref after merge
@mkevins
Respect allowMultipleSelection flag in request from camera source
09a7d22
@ceyhun
Delete react-native-aztec example project
c5d4c7d
@ceyhun
Update react-native-aztec README
9adb864
@chipsnyder
Update gutenberg reference
0886d9f
@koke
Update page templates feature flag name
0dd4671
@chipsnyder
Update Gutenberg
0f5ef66
Merge pull request #1872 from wordpress-mobile/issue/1868-textcutoff
f997bb5 
Fix layout issue in Shortcode
@hypest
Update Gutenberg hash
8403011
@hypest
Merge branch 'develop' into merge-v1.22.0-to-develop
986fe1c
@chipsnyder
Copy link
Contributor

chipsnyder commented Feb 18, 2020 •
edited
Loading

Gallery-1

Gallery-2

  • Gallery block - Insert image from device (failing) - steps
  • Gallery block - Insert image from device (cancel) - steps

Gallery-3

  • Gallery block - Add Gallery Caption - steps
  • Gallery block - Add Gallery Image Caption - steps
  • Gallery block - Try adding same images from WP Media library and moving the images around - steps

Gallery-4

  • Gallery block - Settings: Link to - steps
  • Gallery block - Settings: Column number - steps
  • Gallery block - Settings: Crop images - steps

@lukewalczak
Copy link
Contributor

lukewalczak commented Feb 19, 2020 •
edited
Loading

Sanity tests (iOS)

Tested on device iPhone XS 13.3.1

Button-1

  • Button block - Render custom text color - steps
  • Button block - Render custom background color - steps
  • Button block - Render gradient background color - steps
  • Button block - Check if selection / caret color matches font color - steps

Button-2

  • Button block - Edit text styles - steps
  • Button block - Fallback to default colors in case theme colors are used - steps
  • Button block - New Button is created with the gray color - steps
  • Button block - Settings: Change Button border radius - steps
  • Button block - The newly created button has set background color to the theme-default color in preview - steps
  • Button block - Tapping delete key removes block when Button is empty - steps

Button-3

  • Button block - Settings: Open in new tab - steps
  • Button block - Settings: Link rel - steps
  • Button block - Settings: Link URL - steps
  • Button block - Settings: Remove link - steps
  • Button block - Settings: Synchronize with button options - steps

Button-4

  • Button block - Link in the clipboard is automaticially added into the empty URL field - steps
  • Button block - Toolbar link button is active when Button has link - steps
  • Button block - Button max width is calculated OK inside inner blocks(iOS only) - steps

@jbinda
Copy link
Contributor

jbinda commented Feb 19, 2020 •
edited
Loading

Sanity test (iOS)

Group-1

  • Group - AppenderButton is rendered - steps

  • Group - Deep nesting is possible (iOS only) - steps
    ❌ After add 6th level of nesting the placeholder stops to be visible

  • Group - Check if Group placeholder is visible for the unselected state - steps

  • Group - Check if Group placeholder is render in nested structure - steps

  • Group - Nested block have proper border styling - steps

  • Group - Nested block have proper margins values - steps

  • Group - Nested selection cause applying dimmed style on the rest of blocks - steps

  • Group - Breadcrumbs on FloatingToolbar is properly displayed - steps

  • Group - Navigation up button works as expected - steps

  • Group - Navigation down works according to parent-first approach - steps

  • Group - Cross navigation between blocks works as expected - steps

  • Group - Ungroup button works as expected - steps

  • Group - Check if in DarkMode all components gets proper colors (iOS) - steps

DarkMode-1(iOS)

  • Gallery block - Dark mode - steps
  • Shortcode block - Dark mode - steps
  • Media Text block - Dark mode - steps

DarkMode-2(iOS)

  • Spacer block - Dark mode - steps
  • Button block - Dark mode - steps
  • Group - Dark mode - steps

Spacer-1

  • Spacer block - Settings: Height in pixels - steps

@pinarol
Apart of above test results I have notice one more thing. When the Group has only 1 item inside I would expect the selection after remove that block goes to Group as a parent. It doesn't - currently there is no block selected after proceed with above scenario.

When Group has more than one item the selection goes to block before removed one which I think is something that we expect.

@pinarol
Copy link
Contributor

pinarol commented Feb 19, 2020 •
edited
Loading

Apart of above test results I have notice one more thing. When the Group has only 1 item inside I would expect the selection after remove that block goes to Group as a parent. It doesn't - currently there is no block selected after proceed with above scenario.

@jbinda Thanks for reporting that. It is not a regression or a bug. Actually that looks pretty expected to me, I tried the same scenario and it felt natural. We can do some fine tuning about that kind of details at some point but it is a pretty new block, let’s give it some time and see what kind of user feedback we’ll have soon.

@pinarol
Copy link
Contributor

pinarol commented Feb 19, 2020

After add 6th level of nesting the placeholder stops to be visible

@jbinda I'd consider that an edge case but still, let's track it with an issue, could you be able to open one?

@jbinda
Copy link
Contributor

jbinda commented Feb 19, 2020

After add 6th level of nesting the placeholder stops to be visible

@jbinda I'd consider that an edge case but still, let's track it with an issue, could you be able to open one?

Ok, I have open issue here (#1935) and update test checklist as well

SergioEstevao and others added 4 commits February 20, 2020 11:39
@SergioEstevao
Fix alignment setting.
781782c 
Override set instead of didSet to avoid cross changes of calling
super.set
@SergioEstevao
Add release notes.
f6de8f8
@SergioEstevao
Merge pull request #1938 from wordpress-mobile/issue/1916_fix_align_i…
ffda54d 
…ssues

Issue/1916 fix align issues
@mchowning
Update bundle files
f8a5c85
@mchowning
Copy link
Contributor Author

mchowning commented Feb 21, 2020 •
edited
Loading

I tested all the changes with the latest code and everything looks good to me. In particular, I tested:

The issue with closing and reopening a post while an image is uploading (#1928) was determined to be enough of an edge case that it did not need to be fixed for this release.

Likewise, I agree with @pinarol 's opinion that the placeholder issue with deeply nested blocks (#1935) is an edge case that does not need to be addressed for this release.

cameronvoell
cameronvoell approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Did one last check of the newly merged PRs:

And I spot checked the remaining PRs as well. Seems like we got good coverage testing this release. Approved!

SergioEstevao
SergioEstevao approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a general smoke test of the functionality and then just focused on these two issues:

  • Text align on paragraphs on iOS
  • Emoji on titles
  • Upload of image in the gallery block

All is looking good!

@mchowning mchowning merged commit 4204479 into master Feb 21, 2020
@mchowning mchowning deleted the release/1.23.0 branch February 21, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins left review comments

@cameronvoell cameronvoell cameronvoell approved these changes

@SergioEstevao SergioEstevao SergioEstevao approved these changes

@hypest hypest Awaiting requested review from hypest

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.