Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout issue in Shortcode #1872

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Fix layout issue in Shortcode #1872

merged 2 commits into from
Feb 10, 2020

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Feb 7, 2020

Fixes #1868
Full description in gutenberg WordPress/gutenberg#20097

To test:
1.) Select a shortcode block
2.) Type enough text to wrap to a second line or more

Expect:

  • Text input to grow with content
  • The device should not automatically force an autosuggest change.
  • Some devices/APIs won't show the prompt at all.

3.) Delete text
Expect:

  • Text input to shrink with content

4.) Paste content
Expect:

  • Text input to grow with content
  • The text should have similar wrapping as a prefilled block.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Shortcode block cuts off multiline task
2 participants