[RNMobile] Improve text read by screen readers for BottomSheetSelectControl #4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
…-a11y-improvements' of https://github.com/wordpress-mobile/gutenberg-mobile into version-toolkit/gutenberg/rnmobile/bottom-sheet-control-a11y-improvements
SiobhyB
changed the title
SiobhyB
changed the title
SiobhyB
changed the title
mchowning
approved these changes
May 13, 2022
SiobhyB
deleted the
version-toolkit/gutenberg/rnmobile/bottom-sheet-control-a11y-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs and Installable Builds
gutenberg:[RNMobile] Improve text read by screen readers for BottomSheetSelectControl WordPress/gutenberg#41036 by @SiobhyBiOS:[TESTING ONLY] Improve text read by screen readers for BottomSheetSelectControl WordPress-iOS#18596Android:[TESTING ONLY] Improve text read by screen readers for BottomSheetSelectControl WordPress-Android#16535Description
This PR improves the text that's read by screen readers by the
BottomSheetSelectControlcomponent, adding extra context and making its purpose clearer.Please refer to the Gutenberg PR as the "central PR" with the most up-to-date testing instructions.