-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable VideoPress block on iOS #5692
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
jetpack
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bumped the Jetpack ref to incorporate the changes from Automattic/jetpack#30071. Note that it's not pointing to the latest commit from trunk
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left one small question/comment about the release notes, but nothing at all blocking, going ahead to approve :D 😎
# Conflicts: # bundle/ios/App.js # bundle/ios/App.js.map
Related PRs:
This PR enables the VideoPress block on iOS as it will released first on that platform. In the next few days, we plan to ship the Android version.
NOTE:⚠️ The VideoPress block only works on Simple WPCOM sites.
To test
iOS
Example:
Android
NOTE: Repeat steps 3 and 4 (enable JS Dev Mode) to go back to dev mode.
Example:
PR submission checklist: