Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.94.0 #5706

Merged
merged 6 commits into from
Apr 27, 2023
Merged

Release 1.94.0 #5706

merged 6 commits into from
Apr 27, 2023

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Apr 27, 2023 •
edited by fluiddot
Loading

Release for Gutenberg Mobile 1.94.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Enable VideoPress block on iOS

Allow content that is pasted into the post title to populate the post body correctly

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Apr 27, 2023
Merged
Merged
Merged
@jhnstn jhnstn marked this pull request as ready for review April 27, 2023 19:55
@twstokes twstokes self-requested a review April 27, 2023 20:30
twstokes
twstokes approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@jhnstn jhnstn merged commit 9a181e9 into trunk Apr 27, 2023
@jhnstn jhnstn deleted the release/1.94.0 branch April 27, 2023 22:42
@jhnstn
Copy link
Member Author

jhnstn commented May 3, 2023 •
edited
Loading

⚪ Functionality Test Suite 2 (Android)

Build: 22.3.rc-1
Device: Pixel 5 (Android 13)

DarkMode - 2

  • Spacer block - Dark mode - TC004
  • Buttons block - Dark mode - TC005
  • Group - Dark mode - TC006
  • Columns - Dark mode - TC007

Group - 2

  • Group - Navigation up button works as expected - TC006
  • Group - Navigation down works according to parent-first approach - TC007
  • Group - Cross navigation between blocks works as expected - TC008
  • Group - Check if in DarkMode all components gets proper colors - TC009
  • Group - Check if nested Placeholder block can be replaced - TC010

Spacer - 1

  • Spacer block - Spacer in horizontal layout works as expected - TC001

Buttons - 4

  • Buttons block - Render custom text color - TC013
  • Buttons block - Render custom background color - TC012
  • Buttons block - Render gradient background color - TC014
  • Buttons block - Check if selection / caret color matches font color - TC016
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - TC017

Buttons - 5

  • Buttons block - Edit text styles - TC005
  • Buttons block - Render theme colors - TC015
  • Buttons block - Settings: Change Button border radius - TC011

Buttons - 7

  • Buttons block - Link from the clipboard is presented as an option in the link picker - TC020
  • Buttons block - Toolbar link button is active when Button has link - TC018

Editor Theme - 2

⚠️ - Test group is failing on self hosted Jetpack sites

  • Custom Gradients - Check that custom gradients load in the editor - TC004
  • Offline Support - TC005

Color Settings - 2

@jhnstn
Copy link
Member Author

jhnstn commented May 3, 2023 •
edited
Loading

🟢 Unsupported Block Tests (Android)

Build: 22.3.rc-1
Device: Pixel 5 (Android 13)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites (known issues)
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@jhnstn
Copy link
Member Author

jhnstn commented May 3, 2023 •
edited
Loading

⚪ Writing Flow Checklist (Android)

Build: 22.3.rc-1
Device: Pixel 5 (Android 13)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@fluiddot
Copy link
Contributor

fluiddot commented May 4, 2023 •
edited
Loading

🟢 Writing Flow checklist (iOS)

Build: 22.3.0.1
Device: iPhone 11 (iOS 15.4.1)

General

Rich Text Format

Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@fluiddot
Copy link
Contributor

fluiddot commented May 4, 2023 •
edited
Loading

🟢 Unsupported Block Tests (iOS)

Build: 22.3.0.1
Device: iPhone 11 (iOS 15.4.1)

@fluiddot
Copy link
Contributor

fluiddot commented May 4, 2023 •
edited
Loading

🟢 Included Changes (iOS)

Build: 22.3.0.1
Device: iPhone 11 (iOS 15.4.1)

  • Enable VideoPress block on iOS
  • Allow content that is pasted into the post title to populate the post body correctly

@fluiddot
Copy link
Contributor

fluiddot commented May 4, 2023 •
edited
Loading

🟡 Test Suite 5 (iOS)

Build: 22.3.0.1
Device: iPhone 11 (iOS 15.4.1)

Video block - 1

  • Video block - Insert video from device (failing) - TC001
  • Video block - Close/Re-open post with an ongoing video upload - TC004

Video block - 2

  • Video block - Insert video from device (cancel) - TC002
  • Video block - Close post with an ongoing video upload - TC005
  • Video block - Add Caption - TC003

File block - 1

  • File block - Upload completes successfully from the device library - TC001
  • File block - Insert completes successfully from the WordPress Media library - TC002
  • File block - Upload fails from the device library - TC003
  • File block - Stop the file upload before it completes - TC004

File block - 2

  • File block - Close the post with an ongoing file upload - TC005
  • File block - Replace the selected files - TC006
  • File block - Change the alignment in the File Block - TC007
  • File block - The Link To Block Setting should open - TC008

File block - 3

  • File block - Open link in new tab - TC009
  • File block - Show/hide download button (Block Settings only) - TC010
  • File block - Copy file URL - TC011
  • File block - Close/Re-open post with an ongoing file upload - TC012

Audio block - 1

  • Audio block - Upload completes successfully from the device library - TC001
  • Audio block - Insert completes successfully from the WordPress Media library - TC002

Audio block - 2

  • Audio block - Upload fails from the device library - TC003
  • Audio block - Stop the audio file upload before it completes - TC004

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - TC005
  • Audio block - Replace the selected files - TC006
  • Audio block - Change the alignment in the Audio Block - TC007

Audio block - 4

  • Audio block - Autoplay setting - TC008
  • Audio block - Loop setting - TC009
  • Audio block - Close/Re-open post with an ongoing audio file upload - TC010

Reusable block - 1

Reusable block - 2

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - TC001

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - TC002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twstokes twstokes twstokes approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhnstn @fluiddot @twstokes