Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated "iOS Build" step from CircleCI to Buildkite #6134

Closed
wants to merge 53 commits into from

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Aug 30, 2023

WIP


To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@mokagio mokagio force-pushed the mokagio/move-ios-build-to-buildkite branch from 32f3d1d to f7c662e Compare August 30, 2023 03:30
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 30, 2023

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

1 similar comment
@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@mokagio mokagio force-pushed the mokagio/move-ios-build-to-buildkite branch from a64c392 to cc807b1 Compare September 1, 2023 04:59
@mokagio mokagio force-pushed the mokagio/move-ios-build-to-buildkite branch from 0001577 to f3f519b Compare September 6, 2023 04:05
@mokagio mokagio force-pushed the mokagio/move-ios-build-to-buildkite branch from f3f519b to a2e16f3 Compare September 6, 2023 04:10
@mokagio mokagio force-pushed the mokagio/move-ios-build-to-buildkite branch from a49328e to 0ff8dc7 Compare September 6, 2023 04:20
@mokagio
Copy link
Contributor Author

mokagio commented Sep 6, 2023

Getting some

HTTP Status: 500
{
	"message": "An unknown server-side error occurred while processing the command.
       Original error: Could not extract Info.plist from 'GutenbergDemo.app':
          Plist file doesn't exist:
            '/var/folders/3n/z0_2p7gn03q5x5mt40c4lj1m0000kr/T/202386-3093-1uz43f4.nw69/GutenbergDemo.app/Info.plist'"
}

@mokagio
Copy link
Contributor Author

mokagio commented Sep 6, 2023

Got to the bottom of it, I think.

If you look at the Buildkite logs when zipping the GutenbergDemo.app package, there is indeed no Info.plist. Compare them to the CircleCI ones, and you'll see that they do have the file.

I believe this is happening because the previous step, npm run core test:e2e:build-app:ios failed silently. See logs here because of the provisioning profile issue already noticed in WordPress/gutenberg#54079

@mokagio
Copy link
Contributor Author

mokagio commented Sep 6, 2023

Okay, so the reason was a dumb forgetting that piping output will lose exit code unless explicitly specified.

That is why the build step didn't fail despite the script failing, therefore resulting in the tests running but without access to a fully built .app.

As for the reason why the script, that is the xcodebuild call, failed, by looking at the Buildkite logs once more we can see that there is no iPhone 13 Simulator available so we go back to the code signing process looking using the Mac machine as the target, which fails. I'll fix that next, once established that the set -o pipefail does its job.

@mokagio
Copy link
Contributor Author

mokagio commented Sep 7, 2023

Happy to say that the test annotation and Slack reporting worked fine :)

Screenshot 2023-09-07 at 1 05 52 pm Screenshot 2023-09-07 at 1 06 01 pm

@mokagio
Copy link
Contributor Author

mokagio commented Sep 11, 2023

Closing in favor of #6179, which took these changes minus all the Git noise.

@mokagio mokagio closed this Sep 11, 2023
@mokagio mokagio deleted the mokagio/move-ios-build-to-buildkite branch September 11, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant