-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated "iOS Build" step from CircleCI to Buildkite #6134
Conversation
Notice I moved the other CI steps into a bak file to make iterating faster.
32f3d1d
to
f7c662e
Compare
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
1 similar comment
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
It's unbound in the context of the `command` script. Besides, I already learned what I needed from it.
So I can see what it says in the log, given that it fails to code sign on Buildkite.
This reverts commit a02a549.
Allows skipping the 2.7.5 install in CI
a64c392
to
cc807b1
Compare
Otherwise, the steps will ignore the block. See https://buildkite.com/automattic/gutenberg-mobile/builds/7133
0001577
to
f3f519b
Compare
f3f519b
to
a2e16f3
Compare
a49328e
to
0ff8dc7
Compare
Possibly something I should have done after the Gutenberg sync in 61890f8
Getting some
|
Got to the bottom of it, I think. If you look at the Buildkite logs when zipping the I believe this is happening because the previous step, |
Okay, so the reason was a dumb forgetting that piping output will lose exit code unless explicitly specified. That is why the build step didn't fail despite the script failing, therefore resulting in the tests running but without access to a fully built As for the reason why the script, that is the |
There is no iPhone 13 in our stock stack: https://buildkite.com/automattic/gutenberg-mobile/builds/7164#018a695f-f47a-4488-9baf-6e554109722c/837-838
Closing in favor of #6179, which took these changes minus all the Git noise. |
WIP
To test:
PR submission checklist: