Add coin gecko pro API usage for the governor #4025
Conversation
mdulin2
requested review from
bruce-riley,
claudijd,
SEJeff,
djb15,
panoel and
evan-gray
as code owners
|
Failing tests have been fixed. I'm unsure why tilt is failing though. |
|
Once John's changes for cancel flow are approved at #4016 I'll have to fix a few locations since it touches similar code. |
Good thought! I wasn't sure if testing this small feature was worth the pain of doing something like that. What do you think? Also, it depends on whether we can even connect to the Internet during our tests. |
@djb15 - I saw this comment and wanted to note that I don’t believe secrets for this repo would be available to PRs from forks, so I would not rely on that approach. https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow It may be better to simply give reviewers a “hack” script or the like to prove the updated fetching logic does indeed work with and without an API key and have the unit tests ensure that URL is formatted appropriately. |
Ah thanks, yeah that's not an option then. Anyhow I think the approach we're going for with this now is to avoid adding an internet dependency here in these unit tests: #4025 (comment) |
|
converting to draft while this has conflicts |
|
I accidentally added a test CoinGecko API key in the last commit. I deleted the key from the PR and revoked the key from my coin gecko account. |
johnsaigle
force-pushed
the
coin_gecko_pro
branch
from
e850e82 to
f24499f
Compare
mdulin2
force-pushed
the
coin_gecko_pro
branch
from
815f9ae to
4a88c2d
Compare
johnsaigle
force-pushed
the
coin_gecko_pro
branch
from
4a88c2d to
3267e65
Compare
johnsaigle
force-pushed
the
coin_gecko_pro
branch
from
3267e65 to
2fdfcde
Compare
…cron action for this instead
…cron action for this instead
djb15
force-pushed
the
coin_gecko_pro
branch
from
2fdfcde to
d0ff9fe
Compare
cosmwasm(cw_wormhole): integration tests- initial implementation chore: adding additional vaa parsing tests cosmwasm: added cw_wormhole integration tests and some code cleanup cosmwasm: reverted contract changes Update 0012_ibc_generic_messaging.md with permissionless channel creation information (#4167) The `wormhole-ibc-receiver` contract contains an allowlist of Wormhole chain ID to channel mappings (other side of Cosmos chain). The allowlist is not used when receiving a packet because we don't want to handle the case of a token transfer failure on the other side. Instead, we just emit the message and ignore it in the IBC watcher. I am just updating the documentation to reflect this. node: governor token list update tilt: aptos multi-platform support tilt: sui multi-platform support tilt: node multi-platform support tilt: solana-test-validator multi-platform support tilt: smaller sui image Add coin gecko pro API usage for the governor (#4025) * Add coin gecko pro API usage for the governor * Add in missing parameter for node test * Fix missing parameter in publicrpcserver_test.go * Add in NIT fixes * Change CLI description * Reorder error message so that the important part is not truncated in the logs * Remove network test from unit test. Plan on creating a Github action cron action for this instead * Remove unnecessary '&' from URL path * Add in new parameters for gov from rebase * Fix regression on query creation * Add coin gecko pro API usage for the governor * Add in NIT fixes * Remove network test from unit test. Plan on creating a Github action cron action for this instead --------- Co-authored-by: Maxwell Dulin <strikeout@maxwells-mbp.lan> Co-authored-by: Maxwell Dulin <strikeout@Maxwells-MacBook-Pro.local> node: add amazon kms and benchmark signers (#4168) * add kms and benchmark signers * include context during guardiansigner calls * add error counters and address review comment * address pr comments * address pr comments --------- Co-authored-by: pleasew8t <jason@asymmetric.re> wormchain: add ibc_receiver_test and ict workflow (#4155) Update CODEOWNERS (#4151) sdk: worldchain mainnet SR entry. (#4188) cosmwasm: refactored the to guardianAddress logic wormchain: lower ict setup params to improve stability
In case the Guardians want to use API keys for Coin Gecko, support for the API keys has been added. This changes code in the Guardian and adds a command line flag.
Testing this is difficult because we don't want to include a key in here. Prior to this, I don't think we had tests for the query success from CoinGecko anyway. So, I added tests that make requests to coin gecko using the standard and pro APIs. If the API key isn't specified in the test file, the test is just skipped. If there's a better way to do this or relying on external APIs for builds to succeed is bad practice, then please say something and I'm happy to make changes accordingly.