node: add amazon kms and benchmark signers #4168
Merged
+661
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleasew8t
requested review from
bruce-riley,
panoel,
evan-gray,
claudijd,
SEJeff,
djb15 and
johnsaigle
as code owners
bruce-riley
reviewed
Nov 26, 2024
bruce-riley
reviewed
Nov 26, 2024
bruce-riley
previously approved these changes
Nov 27, 2024
pires
previously approved these changes
Dec 2, 2024
There was a problem hiding this comment.
I've been involved in reviewing this before this PR was open so I want to signal I think this is in a good shape to be seriously considered for merge by other more seasoned maintainers.
That said, @andreclaro and xLabs Nodes team will be soaking this in testnet and report back 🙏🏻
djb15
reviewed
Dec 2, 2024
pleasew8t
force-pushed
the
add-kms-and-benchmark-signers
branch
from
a923d97 to
ef4ad2d
Compare
djb15
reviewed
Dec 6, 2024
djb15
approved these changes
Dec 9, 2024
bruce-riley
approved these changes
Dec 10, 2024
pleasew8t
force-pushed
the
add-kms-and-benchmark-signers
branch
from
6290322 to
d3bead1
Compare
kakucodes
pushed a commit
that referenced
this pull request
Dec 18, 2024
cosmwasm(cw_wormhole): integration tests- initial implementation chore: adding additional vaa parsing tests cosmwasm: added cw_wormhole integration tests and some code cleanup cosmwasm: reverted contract changes Update 0012_ibc_generic_messaging.md with permissionless channel creation information (#4167) The `wormhole-ibc-receiver` contract contains an allowlist of Wormhole chain ID to channel mappings (other side of Cosmos chain). The allowlist is not used when receiving a packet because we don't want to handle the case of a token transfer failure on the other side. Instead, we just emit the message and ignore it in the IBC watcher. I am just updating the documentation to reflect this. node: governor token list update tilt: aptos multi-platform support tilt: sui multi-platform support tilt: node multi-platform support tilt: solana-test-validator multi-platform support tilt: smaller sui image Add coin gecko pro API usage for the governor (#4025) * Add coin gecko pro API usage for the governor * Add in missing parameter for node test * Fix missing parameter in publicrpcserver_test.go * Add in NIT fixes * Change CLI description * Reorder error message so that the important part is not truncated in the logs * Remove network test from unit test. Plan on creating a Github action cron action for this instead * Remove unnecessary '&' from URL path * Add in new parameters for gov from rebase * Fix regression on query creation * Add coin gecko pro API usage for the governor * Add in NIT fixes * Remove network test from unit test. Plan on creating a Github action cron action for this instead --------- Co-authored-by: Maxwell Dulin <strikeout@maxwells-mbp.lan> Co-authored-by: Maxwell Dulin <strikeout@Maxwells-MacBook-Pro.local> node: add amazon kms and benchmark signers (#4168) * add kms and benchmark signers * include context during guardiansigner calls * add error counters and address review comment * address pr comments * address pr comments --------- Co-authored-by: pleasew8t <jason@asymmetric.re> wormchain: add ibc_receiver_test and ict workflow (#4155) Update CODEOWNERS (#4151) sdk: worldchain mainnet SR entry. (#4188) cosmwasm: refactored the to guardianAddress logic wormchain: lower ict setup params to improve stability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon KMS Guardian Signer
This PR adds an Amazon AWS KMS Guardian signer, allowing observations to be signed using KMS! The new signer can be used by specifying the ARN of the KMS key to use, through the
--guardianSignerUricommandline argument, as follows:--guardianSignerUri=amazonkms://<ARN>NOTE For the best possible performance, it is recommended that the Guardian be run from an EC2 instance that is in the same region as the KMS key.
The KMS key's spec should be
ECC_SECG_P256K1, and should be enabled for signing. In order for the Guardian to authenticate against the KMS service, one of two options are available:~/.aws/credentialsfile. (example here).Benchmark Signer
The PR also includes a benchmark signer, which wraps any other signer, logging signing and verification latency to prometheus histograms. External signing services might at times introduce unwanted latency, and if an event occurs where observation processing is particularly slow, the histograms would provide insight into whether or not the signing service is to blame.
NOTE
This is a redo of a previous pull request, which Pires spent time looking at. Below are key points following that review that informs the current state of the code:
Contexts should be supplied to signing, verification and public key retrieval, as these functions potentially interact with 3rd party services that could timeout or block indefinitely.GuardianSignerconstructor (NewGuardianSignerFromUri) accepts aContext, as the new signer might need to interact with the 3rd party service to validate configurations (such as theAmazonKmssigner). A different approach could be to have the constructor define its own context, to avoid the necessity of passing a context to it.