Bonus Armor DB Refactor #3016
Merged
Bonus Armor DB Refactor #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 1, 2023 17:14
creation, rather than requiring tank sims to do this individually. Updated tank sim stat dependencies accordingly, such that no test results changed besides the presentation of stats (which now correctly shows the total Bonus Armor contribution to the displayed Armor value). Changes to be committed: modified: assets/database/db.bin modified: assets/database/db.json modified: assets/database/leftover_db.bin modified: assets/database/leftover_db.json modified: sim/common/wotlk/metagems.go modified: sim/core/stats/deps.go modified: sim/deathknight/deathknight.go modified: sim/deathknight/presences.go modified: sim/deathknight/talents_frost.go modified: sim/deathknight/tank/TestBloodTank.results modified: sim/druid/druid.go modified: sim/druid/tank/TestFeralTank.results modified: sim/paladin/holy/TestHoly.results modified: sim/paladin/paladin.go modified: sim/paladin/protection/TestProtection.results modified: sim/paladin/talents.go modified: sim/shaman/elemental/TestElemental.results modified: sim/shaman/restoration/TestRestoration.results modified: sim/shaman/shaman.go modified: sim/warrior/dps/TestArms.results modified: sim/warrior/dps/TestFury.results modified: sim/warrior/protection/TestProtectionWarrior.results modified: sim/warrior/talents.go modified: sim/warrior/warrior.go modified: tools/database/enchant_overrides.go modified: tools/database/wowhead_tooltips.go
Changes to be committed: modified: sim/deathknight/presences.go modified: sim/deathknight/tank/TestBloodTank.results
Changes to be committed: modified: sim/common/wotlk/metagems.go modified: sim/deathknight/tank/TestBloodTank.results modified: sim/warrior/protection/TestProtectionWarrior.results
Armor on gear. Changes to be committed: modified: sim/deathknight/talents_frost.go modified: sim/deathknight/tank/TestBloodTank.results modified: sim/paladin/holy/TestHoly.results modified: sim/paladin/protection/TestProtection.results modified: sim/paladin/talents.go modified: sim/warrior/protection/TestProtectionWarrior.results modified: sim/warrior/talents.go
Changes to be committed: modified: ui/feral_tank_druid/sim.ts modified: ui/protection_paladin/sim.ts modified: ui/protection_warrior/sim.ts modified: ui/tank_deathknight/sim.ts
Changes to be committed: modified: ui/tank_deathknight/sim.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits are separated for ease of debugging: