Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bonus Armor DB Refactor #3016

Merged
merged 7 commits into from
May 2, 2023
Merged

Bonus Armor DB Refactor #3016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
356893e
Refactored item DB parser to distinguish Armor from Bonus Armor at DB
May 2, 2023
0098d64
Fixed Frost Presence to not scale Bonus Armor on gear.
May 2, 2023
f23973b
Fixed Austere Earthsiege Diamond to not scale Bonus Armor on gear.
May 2, 2023
ca86409
Fixed the Warrior, Paladin, and DK Toughness talents to not scale Bonus
May 2, 2023
c0641d8
Added default Bonus Armor EP to all tank sims.
May 2, 2023
a9ae4b5
Typo fix for DK UI.
May 2, 2023
4565623
Merge branch 'master' of https://github.com/wowsims/wotlk
May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified assets/database/db.bin
View file
Open in desktop
Binary file not shown.
660 changes: 330 additions & 330 deletions assets/database/db.json
View file
Open in desktop

Large diffs are not rendered by default.

Binary file modified assets/database/leftover_db.bin
View file
Open in desktop
Binary file not shown.
1,738 changes: 869 additions & 869 deletions assets/database/leftover_db.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions sim/core/stats/deps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ var safeDepsOrder = []Stat{
Stamina,
Intellect,
Spirit,
BonusArmor,
Armor,
AttackPower,
RangedAttackPower,
Expand Down
1 change: 1 addition & 0 deletions sim/deathknight/deathknight.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,7 @@ func NewDeathknight(character core.Character, inputs DeathknightInputs, talents
dk.AddStatDependency(stats.Agility, stats.Dodge, core.DodgeRatingPerDodgeChance/84.74576271)
dk.AddStatDependency(stats.Strength, stats.AttackPower, 2)
dk.AddStatDependency(stats.Strength, stats.Parry, 0.25)
dk.AddStatDependency(stats.BonusArmor, stats.Armor, 1)

dk.PseudoStats.CanParry = true
dk.PseudoStats.GracefulCastCDFailures = true
Expand Down
Loading