Revert "Make transient test more robust against added transients by core" #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swissspidy This will not only remove the disabling of the WP cron, but also the splitting up of the checks that were broken before because a recent version of Core added block style caching. |
schlessera
requested changes
Aug 7, 2024
| # We set `WP_DEVELOPMENT_MODE` to stop WordPress from automatically creating | ||
| # additional transients which cause some steps to fail when testing. | ||
| And I run `wp config set WP_DEVELOPMENT_MODE all` | ||
| And I run `wp config set DISABLE_WP_CRON true --raw` |
Comment on lines
+408
to
-418
| name,value,expiration | ||
| foo,bar,false | ||
| """ | ||
| And STDOUT should contain: | ||
| """ | ||
| foo2,bar2,95649119999 | ||
| """ | ||
| And STDOUT should contain: | ||
| """ |
Comment on lines
+461
to
-476
| name,value,expiration | ||
| foo,bar,false | ||
| """ | ||
| And STDOUT should contain: | ||
| """ | ||
| foo2,bar2,95649119999 | ||
| """ | ||
| And STDOUT should contain: | ||
| """ |
|
I went ahead and merged #100 instead, a full revert is not possible due to the contents of the single commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #98
Alternative to #100