-
Notifications
You must be signed in to change notification settings - Fork 25
Revert "Make transient test more robust against added transients by core" #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,8 +60,6 @@ Feature: Manage WordPress transient cache | |
# We set `WP_DEVELOPMENT_MODE` to stop WordPress from automatically creating | ||
# additional transients which cause some steps to fail when testing. | ||
And I run `wp config set WP_DEVELOPMENT_MODE all` | ||
And I run `wp config set DISABLE_WP_CRON true --raw` | ||
|
||
And I run `wp transient list --format=count` | ||
And save STDOUT as {EXISTING_TRANSIENTS} | ||
And I run `expr {EXISTING_TRANSIENTS} + 2` | ||
|
@@ -77,7 +75,6 @@ Feature: Manage WordPress transient cache | |
And I run `wp transient set foo2 bar2 600` | ||
And I run `wp transient set foo3 bar3 --network` | ||
And I run `wp transient set foo4 bar4 600 --network` | ||
|
||
And I run `wp transient delete --all` | ||
Then STDOUT should be: | ||
""" | ||
|
@@ -408,14 +405,9 @@ Feature: Manage WordPress transient cache | |
When I run `wp transient list --format=csv` | ||
Then STDOUT should contain: | ||
""" | ||
name,value,expiration | ||
foo,bar,false | ||
""" | ||
And STDOUT should contain: | ||
""" | ||
foo2,bar2,95649119999 | ||
""" | ||
And STDOUT should contain: | ||
""" | ||
Comment on lines
+408
to
-418
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs to stay. |
||
foo3,bar3,1321009871 | ||
""" | ||
|
||
|
@@ -466,14 +458,9 @@ Feature: Manage WordPress transient cache | |
When I run `wp transient list --format=csv` | ||
Then STDOUT should contain: | ||
""" | ||
name,value,expiration | ||
foo,bar,false | ||
""" | ||
And STDOUT should contain: | ||
""" | ||
foo2,bar2,95649119999 | ||
""" | ||
And STDOUT should contain: | ||
""" | ||
Comment on lines
+461
to
-476
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs to stay. |
||
foo3,bar3,1321009871 | ||
""" | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay to go.