Skip to content

Revert "Make transient test more robust against added transients by core" #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Revert "Make transient test more robust against added transients by core" #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions features/transient.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ Feature: Manage WordPress transient cache
# We set `WP_DEVELOPMENT_MODE` to stop WordPress from automatically creating
# additional transients which cause some steps to fail when testing.
And I run `wp config set WP_DEVELOPMENT_MODE all`
And I run `wp config set DISABLE_WP_CRON true --raw`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay to go.


And I run `wp transient list --format=count`
And save STDOUT as {EXISTING_TRANSIENTS}
And I run `expr {EXISTING_TRANSIENTS} + 2`
Expand All @@ -77,7 +75,6 @@ Feature: Manage WordPress transient cache
And I run `wp transient set foo2 bar2 600`
And I run `wp transient set foo3 bar3 --network`
And I run `wp transient set foo4 bar4 600 --network`

And I run `wp transient delete --all`
Then STDOUT should be:
"""
Expand Down Expand Up @@ -408,14 +405,9 @@ Feature: Manage WordPress transient cache
When I run `wp transient list --format=csv`
Then STDOUT should contain:
"""
name,value,expiration
foo,bar,false
"""
And STDOUT should contain:
"""
foo2,bar2,95649119999
"""
And STDOUT should contain:
"""
Comment on lines +408 to -418
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to stay.

foo3,bar3,1321009871
"""

Expand Down Expand Up @@ -466,14 +458,9 @@ Feature: Manage WordPress transient cache
When I run `wp transient list --format=csv`
Then STDOUT should contain:
"""
name,value,expiration
foo,bar,false
"""
And STDOUT should contain:
"""
foo2,bar2,95649119999
"""
And STDOUT should contain:
"""
Comment on lines +461 to -476
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to stay.

foo3,bar3,1321009871
"""

Expand Down