Improve deleting site transients

[ocean90]

• Delete also expired site transients.
• Add multisite support for site transients.
• Ensure correct counts due to transient timeouts being its own option.
• Add more tests for delete commands.

Fixes #30.
Fixes #41.

[schlessera]

Awesome work, @ocean90, looking good already!

I've written down a few remarks concerning the algorithm.

Also, I'd like to have the following tests added to the Behat suite as well:

• deleting expired/all transients from site meta
• deleting expired/all transients from multisite

(I notice now that the --expired is not tested at all, though...)

[schlessera]

Another observation: I just saw that you've replaced esc_like() because it broke your tests on older WP core versions. We have a polyfill for that case that you can use instead: https://github.com/wp-cli/wp-cli/blob/v2.0.1/php/utils.php#L1408-L1424

[ocean90]

@schlessera After 90af941 three tests will fail because when deleting all transients the count is always one more. It seems to be that during each test WP cron is triggered which means _transient_doing_cron exists. Are you aware of this? Shouldn't cron be disabled like core is doing?

[schlessera]

@ocean90 Oh, interesting. We should definitely disable cron for the tests, would also reduce the running time as well I guess.

[schlessera]

@ocean90 I made a change to wp-cli/wp-cli-tests to disable WP Cron by default for running the tests: wp-cli/wp-cli-tests#28

Once this is merged, I'll tag a new release that you can then constrain the Composer file to for this package.

[ocean90]

@schlessera Thanks! I replaced FeatureContext.php locally and the tests are now passing. In terms of reducing the running time, it's actually the opposite. It's slower by ~3s. 🤷‍♂️

[schlessera]

@ocean90 Release v2.0.11 of wp-cli/wp-cli-tests was now tagged. You can update the composer.json in your PR to require-dev ^2.0.11 of that package.

[schlessera]

@ocean90 I felt the tests had become a bit haphazard now from the multiple changes.

I tried to restructure them to make them more consistent and to verify the expectations I would currently have of the logic.

With this change, I have the following two failures:

01. $ wp transient get foo3 --network

    Warning: Transient with key "foo3" is not set.
    cwd: /tmp/wp-cli-test-run-transient.feature.119-5bf661f2899b14.09807233/
    run time: 0.43985104560852
    exit status: 0
    In step `When I run `wp transient get foo3 --network`'.     # vendor/wp-cli/wp-cli-tests/features/steps/when.php:29
    From scenario `Deleting expired transients on single site'. # features/transient.feature:119
    Of feature `Manage WordPress transient cache'.              # features/transient.feature

02. $ wp transient delete --expired --network
    Success: No expired transients found.

    cwd: /tmp/wp-cli-test-run-transient.feature.277-5bf6620361a5a2.52144689/
    run time: 0.43504905700684
    exit status: 0
    In step `Then STDOUT should be:'.                           # vendor/wp-cli/wp-cli-tests/features/steps/then.php:17
    From scenario `Deleting expired transients on multisite'.   # features/transient.feature:277
    Of feature `Manage WordPress transient cache'.              # features/transient.feature

According to my current understanding, this would point to issues with the code, nto the tests, but I might be missing something obvious (it's early in the morning, after all).

Can you look into the tests to help me find out whether my expectations or the code are off (we can discuss in Slack if you prefer)?

[schlessera]

Thanks for the great contribution, @ocean90 !