Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edge case handling checksum verification of Hello Dolly #119

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Add edge case handling checksum verification of Hello Dolly #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2e89e5
Add edge case handling for Hello Dolly (Core vs Plugin)
shawnhooper Nov 10, 2023
9559212
Compare hello.php against core checksum instead of plugin repo
shawnhooper Nov 10, 2023
fe3a445
Fixed PHPCS Linting errors
shawnhooper Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions features/checksum-plugin.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,3 +215,12 @@ Feature: Validate checksums for WordPress plugins
"""
Verified 1 of 1 plugins.
"""

Scenario: Verifies Hello Dolly
Given a WP install

When I run `wp plugin verify-checksums hello`
Then STDOUT should contain:
"""
Verified 1 of 1 plugins.
"""
30 changes: 28 additions & 2 deletions src/Checksum_Plugin_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ public function __invoke( $args, $assoc_args ) {
continue;
}

if ( 'hello' === $plugin->name ) {
$this->verify_hello_dolly_from_core( $assoc_args );
continue;
}

if ( false === $version ) {
WP_CLI::warning( "Could not retrieve the version for plugin {$plugin->name}, skipping." );
++$skips;
Expand Down Expand Up @@ -143,7 +148,6 @@ public function __invoke( $args, $assoc_args ) {
if ( ! $strict && $this->is_soft_change_file( $file ) ) {
continue;
}

$result = $this->check_file_checksum( dirname( $plugin->file ) . '/' . $file, $checksums[ $file ] );
if ( true !== $result ) {
$this->add_error( $plugin->name, $file, is_string( $result ) ? $result : 'Checksum does not match' );
Expand Down Expand Up @@ -173,6 +177,29 @@ public function __invoke( $args, $assoc_args ) {
);
}

private function verify_hello_dolly_from_core( $assoc_args ) {
$file = 'hello.php';
$wp_version = get_bloginfo( 'version', 'display' );
$insecure = (bool) Utils\get_flag_value( $assoc_args, 'insecure', false );
$wp_org_api = new WpOrgApi( [ 'insecure' => $insecure ] );
$locale = '';

try {
$checksums = $wp_org_api->get_core_checksums( $wp_version, empty( $locale ) ? 'en_US' : $locale );
} catch ( Exception $exception ) {
WP_CLI::error( $exception );
}

if ( ! is_array( $checksums ) || ! isset( $checksums['wp-content/plugins/hello.php'] ) ) {
WP_CLI::error( "Couldn't get hello.php checksum from WordPress.org." );
}

$md5_file = md5_file( $this->get_absolute_path( '/' ) . $file );
if ( $md5_file !== $checksums['wp-content/plugins/hello.php'] ) {
$this->add_error( 'hello', $file, 'Checksum does not match' );
}
}

/**
* Adds a new error to the array of detected errors.
*
Expand Down Expand Up @@ -255,7 +282,6 @@ private function check_file_checksum( $path, $checksums ) {
&& array_key_exists( 'sha256', $checksums )
) {
$sha256 = $this->get_sha256( $this->get_absolute_path( $path ) );

return in_array( $sha256, (array) $checksums['sha256'], true );
}

Expand Down