mutations return cartItem total excluding tax, even if the settings in WP are different

[MobyDigg]

Describe the bug
The addToCart mutation (and all others too) returns the total price of an cartItem always excluding the respective taxes. Therefore the value is always equal to subtotal…

To Reproduce

mutation test {
  addToCart(input: {productId: ID!, variationId: ID!}) {
    cartItem {
      subtotal
      subtotalTax
      tax
    }
  }
}

returns in my case:

"data": {
    "addToCart": {
      "cartItem": {
        "subtotal": "172€",
        "subtotalTax": "27€",
        "tax": "27€",
        "total": "172€",
        "quantity": 1,
        "key": "e387168c9b6c258ba35c924e9710c903"
      }
    }
  },

Expected behavior
If you set the setting in WooCommerce to true, that prices are shown including taxes, total should return the added value of subtotal + subtotalTax.

[davevanhoorn]

I checked the source code and the plugin seems to use only native WooCommerce functions. So I looked further and changed the following:

1. Go to WooCommerce generic settings
2. Uncheck "activate taxes" OR set your default client location to "Shop address"

That did it for me.

Edit: a better answer might be that WooCommerce doesn't know the customer location in your FE (yet) and because of that, doesn't apply any tax.

[sidyes]

I checked the source code and the plugin seems to use only native WooCommerce functions. So I looked further and changed the following:

1. Go to WooCommerce generic settings
2. Uncheck "activate taxes" OR set your default client location to "Shop address"

That did it for me.

Edit: a better answer might be that WooCommerce doesn't know the customer location in your FE (yet) and because of that, doesn't apply any tax.

I have the same issue and changing the default client location to the shop location did not solve it.

I dont want to uncheck "activate taxes" as I want them to be calculated. Only issue is that subtotal and total are always the same for a product.

Any other suggestions?
@MobyDigg: how did you solve that issue?

[davevanhoorn]

@sidyes and @MobyDigg, I did some searching and found the following.

I compared the default WordPress theme and my FE and there was a difference even though the settings in WordPress and WooCommerce are the same. These are my settings in WordPress:

• I enter product prices in WooCommerce including tax
• I want to show all prices including tax (also during checkout and in the cart)

The default WordPress theme does show the prices including tax, my GraphQL FE does not show the prices including tax.

The WordPress theme uses the following function to calculate the prices of the line items in the cart: get_cart_subtotal();
This plugin uses the following function to calculate the prices of the line items in the cart: get_subtotal();

It's weird and confusing that those two functions differ so much (they're core WooCommerce). One of them does manually add the tax when the WooCommerce option is enabled (line #1968) and the other one doesn't.

I've solved the issue by editing this plugin and adding the calculation to the GraphQL response manually:

File: class-cart-type.php
Line: 49
Version: 0.10.0

Instead of:

$price = ! is_null( $source->get_subtotal() ) ? $source->get_subtotal() : 0;
return \wc_graphql_price( $price );

I write:

if ($source->display_prices_including_tax()) {
  $price_without_tax = ! is_null( $source->get_subtotal() ) ? $source->get_subtotal() : 0;
  $tax = ! is_null( $source->get_subtotal_tax() ) ? $source->get_subtotal_tax() : 0;
  $price = $price_without_tax + $tax;
} else {
  $price = ! is_null( $source->get_subtotal() ) ? $source->get_subtotal() : 0;
}

return \wc_graphql_price( $price );

I did this for the cartItem's "total" field and for the cart "subTotal" field, since these are the ones I use in my front-end.

I'm not sure what a more solid solution would be, but maybe this helps you further.

[mraf]

@davevanhoorn solution is good and working when you want to add tax to cartItem "subTotal" field. "total" field is working ok out of the box (tax included)

I also looked into this file which @davevanhoorn edited 🥇 (many thanks) and I modified his code a little bit

you can find this file here

wp-graphql-woocommerce/includes/type/object/class-cart-type.php

@MobyDigg

Instead editing Line: 49, go and edit Line 284 where line_total is shown

$price = isset( $source['line_total'] ) ? floatval( $source['line_total'] ) : null;
return \wc_graphql_price( $price );

and replace with

$price_without_tax = isset( $source['line_total'] ) ? floatval( $source['line_total'] ) : null;
                $tax = isset( $source['line_tax'] ) ? floatval( $source['line_tax'] ) : null;
                $price = $price_without_tax + $tax;               
                return \wc_graphql_price( $price );

Settings in WordPress:

• product prices in WooCommerce including tax

Thanks to his idea total is returning value subtotal + subtotalTax

[mraf]

Furthermore I noticed that method displayed above can be also used for calculate discount total with TAX

source: the same file wp-graphql-woocommerce/includes/type/object/class-cart-type.php
edit line: 66

$price = ! is_null( $source->get_discount_total() ) ? $source->get_discount_total() : 0;
return \wc_graphql_price( $price );

replace with

$price_without_tax = ! is_null( $source->get_discount_total() ) ? $source->get_discount_total() : 0;
                $tax = ! is_null( $source->get_discount_tax() ) ? $source->get_discount_tax() : 0;
                $price = $price_without_tax + $tax;               
                return \wc_graphql_price( $price );

[davevanhoorn]

@kidunot89 is adding the tax depending on the WC setting something you'd consider this plugin is responsible to handle? Or do you think that WooCommerce should do this in get_subtotal() like they do in get_cart_subtotal()?

If you think this plugin should take care of it maybe @mraf or me can make a PR with the applied fixes

[florianbepunkt]

A PR that fixes this issue would be great. I think this is a bug that should be fixed in this plugin (in WooCommerce it works, regardless whether their implementation/naming of things is a bit confusing).

In the European Union, at least in Germany, you are legally obliged to show prices to B2C customers including taxes. This is one of the reasons why there is an option for this in WooCommerce. GraphQL should respect this setting and show prices inlcuding vat. The problem exists with the cart items total as well as contentsTotal.

@kidunot89 Are you open for a PR?

[kidunot89]

@florianbepunkt Always open to PRs

[florianbepunkt]

@kidunot89 #567

[kidunot89]

@florianbepunkt I reviewed it. Fix the linting issue (Looks like extra whitespace in two places), and we'll be all set to merge it.