fix: respect woocommerce tax display settings in cart #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| ? $source->get_cart_contents_total() | ||
| if ( $source->display_prices_including_tax() ) { | ||
| $cart_subtotal = $source->get_subtotal() + $source->get_subtotal_tax(); | ||
| } else { |
There was a problem hiding this comment.
The method register_cart uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
|
Code Climate has analyzed commit 88f54ae and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 87.5% (50% is the threshold). This pull request will bring the total coverage in the repository to 77.0% (0.0% change). View more on Code Climate. |
kidunot89
requested changes
Oct 14, 2021
There was a problem hiding this comment.
@florianbepunkt It's already covered in CI, but you're failing the linter. Fix that and we should be all good to merge this.
|
Fixed the whitespace issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
Nope. Terrible sorry, PHP is not my hometurf. I have no idea
What does this implement/fix? Explain your changes.
The issue: Cart response does always show item and contents total without taxes, regardless of the respective settings in WooCommerce (show prices including tax). This applied to cart item's
totalas well as cart'scontentsTotalThe fix: I copied the relevant parts from Woocommerce Core
Does this close any currently open issues?
Fixes #405
…
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
Kudos to @davevanhoorn and @mraf for their work shown in #405
Where has this been tested?