-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #789 Fix error displayed when using generate missing next-gen versions button #805
Conversation
Shouldn't this file be modified/updated as well ? |
I can't replicate it, did you have AVIF conversion enabled or not? |
Avif was disabled when I checked this but with Avif enabled, I still get the error. |
@jeawhanlee What kind of environment did you use? Was it a local or live one? |
@piotrbak A local |
@Tabrisrp Are we okay with this comment made by @Miraeld? @jeawhanlee let's see if QA will be able to reproduce this problem, if it's there we should also check if it's a regression when comparing to the current trunk version. |
Yes it's fine we can update the minified files at the end |
@Tabrisrp Thanks for the PR. Got the same error mentioned by @jeawhanlee on both local and https://imagify.rocketlabsqa.ovh/ while AVIF is enabled or disabled. can you please check 🙏 (working fine on trunk) |
It might be related to the fixes done in #806 |
Description
Remove avif as a supported mime type to prevent the error reported, as the format is not currently supported by the Imagick/GD implementation in WP (coming in 6.5).
Also update the ajax URL identifier for the generate missing next-gen versions in the JS file.
Fixes #789
Type of change
Checklists
Feature validation
Code style
Observability