-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #796: Auto generation of AVIF on save #806
Merged
remyperona
merged 6 commits into
feature/avif
from
fix/796-auto-generation-on-settings-save
Feb 22, 2024
Merged
Closes #796: Auto generation of AVIF on save #806
remyperona
merged 6 commits into
feature/avif
from
fix/796-auto-generation-on-settings-save
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miraeld
added
priority: high
Issues which should be resolved as quickly as possible
AVIF
Avif branch/feature
labels
Feb 19, 2024
Miraeld
force-pushed
the
fix/796-auto-generation-on-settings-save
branch
from
February 19, 2024 15:21
0894c15
to
d11fefb
Compare
Miraeld
force-pushed
the
fix/796-auto-generation-on-settings-save
branch
from
February 19, 2024 15:22
d11fefb
to
52edeb7
Compare
There is some conflicts to fix after the merge of my PR to the main branch |
@Miraeld Could you fix the codacy errors, they are mostly related to phpcs. |
remyperona
requested changes
Feb 20, 2024
remyperona
approved these changes
Feb 21, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #796
Documentation
User documentation
Fix the issue related to the auto-optimization on save while AVIF is being enable.
Technical documentation
When we save the Imagify settings, we get to a callback which will check if the AVIF is enable or not.
If it is, we will start optimizing the images when AVIF is missing in order to generate these AVIF versions of images.
Type of change
Checklists
Feature validation
Code style
Observability