Closes #6993: Add a condition to bailout

[Miraeld]

Description

Fixes #6993

It won't show a fatal error if the string is the wrong type.

Type of change

• Bug fix (non-breaking change which fixes an issue).

Detailed scenario

Refer to the issue.

Technical description

Documentation

This pull request includes a small but important change to the inc/Engine/Optimization/RegexTrait.php file. The change ensures that the html_replace property is a string before checking if it is empty.

• inc/Engine/Optimization/RegexTrait.php: Modified the restore_html_comments method to check if html_replace is a string before verifying if it is empty.

New dependencies

None

Risks

None

Mandatory Checklist

Code validation

• I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I implemented built-in tests to cover the new/changed code.

Code style

• I wrote a self-explanatory code about what it does.
• I protected entry points against unexpected inputs.
• I did not introduce unnecessary complexity.
• Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

[jeawhanlee]

We have tests and phpstan checks failing

[Miraeld]

@jeawhanlee Yea, I've fixed the code, I did put the wrong variable in the check. 🙏

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 93fef5c1	✅ 100.00% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (93fef5c)	Report Missing	Report Missing	Report Missing
Head commit (6df1612)	39333	17143	43.58%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#7251)	1	1	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[Khadreal]

QA done:
testrail-report-700.pdf

[Khadreal]

E2E Tests(lcp && llcssbg) are passing