Skip to content

Closes #6993: Add a condition to bailout #7251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Closes #6993: Add a condition to bailout #7251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f57c775
Closes #6993: Add a condition to bailout
Miraeld Jan 27, 2025
6df1612
Fix phpstan
Miraeld Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inc/Engine/Optimization/RegexTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ protected function replace_html_comment( $match ) { // phpcs:ignore Universal.Na
* @return string
*/
protected function restore_html_comments( $html ) {
if ( empty( $this->html_replace ) ) {
if ( ! is_string( $html ) || empty( $this->html_replace ) ) { // @phpstan-ignore-line For some reason, html could be null for some users, and we can't find a way to reproduce it.
return $html;
}

Expand Down
Loading