Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content Replacment null values #2037

Closed
1 task done
colinmurphy opened this issue Feb 7, 2025 · 0 comments · Fixed by #2038
Closed
1 task done

Content Replacment null values #2037

colinmurphy opened this issue Feb 7, 2025 · 0 comments · Fixed by #2038
Assignees
@colinmurphy
Labels
type: bug Issue that causes incorrect or unexpected behavior

Comments

@colinmurphy
Copy link
Contributor

Description

There is a bug with FaustWP not allowing null values for the function callback content_replacment

Steps to reproduce

If you pass a null value for content_replacement, it will throw an error as the function expects a string.

Additional context

No response

@faustwp/core Version

N/A

@faustwp/cli Version

N/A

FaustWP Plugin Version

1.6.0

WordPress Version

6.7

Additional environment details

Issue caused by PR release #2014

Please confirm that you have searched existing issues in the repo.

  • Yes
@colinmurphy colinmurphy self-assigned this Feb 7, 2025
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Headless OSS Feb 7, 2025
@colinmurphy colinmurphy added the type: bug Issue that causes incorrect or unexpected behavior label Feb 7, 2025
@colinmurphy colinmurphy moved this from 🆕 Backlog to 🏗 In progress in Headless OSS Feb 7, 2025
@colinmurphy colinmurphy mentioned this issue Feb 7, 2025
Merged
3 tasks
colinmurphy added a commit that referenced this issue Feb 7, 2025
@colinmurphy
Added changeset. Fixes #2037
7086674
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Closed in Headless OSS Feb 7, 2025
@colinmurphy colinmurphy moved this from ✅ Closed to Merged ready to release in Headless OSS Feb 7, 2025
@colinmurphy colinmurphy mentioned this issue Feb 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colinmurphy colinmurphy

Labels
type: bug Issue that causes incorrect or unexpected behavior
Projects
Headless OSS
Status: Merged ready to release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug: Fixed content replacment to allow null values wpengine/faustjs
1 participant
@colinmurphy