Bug: Fixed content replacment to allow null values #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…null values. Added unit tests and added a try and catch aswell to catch any future issues.
🦋 Changeset detectedLatest commit: b4b6960 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
…com/wpengine/faustjs into bug-content-replacement-null-values
colinmurphy
changed the title
theodesp
reviewed
Feb 7, 2025
theodesp
reviewed
Feb 7, 2025
theodesp
approved these changes
Feb 7, 2025
…h any futher errors.
theodesp
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2037
Tasks
Description
Issue since 1.6.0 where by if you pass a null value for content_replacement it will throw a 500 error.
In 1.6.0 we changed the method signature for content_replacement from
content_replacement($content)tocontent_replacement( string $content)which caused issues for anyone passing a null value for content replacement in Faust WP.Related Issue(s):
#2037
Testing
Tested locally with both single and multisite.
Screenshots
Testing content replacement on multisite.
Documentation Changes
N/A
Dependant PRs
N/A