[wpimath] Make Rotation2d constexpr using gcem #2705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekma
force-pushed
the
constexpr-rotation2d
branch
4 times, most recently
from
b5bf599
to
ad3abff
Compare
|
Per Thad, the Windows build breakage appears to be related to microsoft/STL#519. Workaround is to explicitly cast the input to double. |
prateekma
force-pushed
the
constexpr-rotation2d
branch
2 times, most recently
from
dabe6dc
to
9945df2
Compare
PeterJohnson
reviewed
Oct 5, 2020
prateekma
force-pushed
the
constexpr-rotation2d
branch
from
9945df2
to
97207f1
Compare
|
This pessimizes non-constexpr usage. C++20 will provide std::is_constant_evaluated() that will fix this issue, and we should wait for that to be available on our target compilers/platforms. |
|
Closing until C++20 is supported by our compilation tools on all platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the GCEM library (https://github.com/kthohr/gcem) for compile-time cmath functions in order to make Rotation2d constexpr.