Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpilib] Add hex string constructor to Color and Color8Bit #5063

Merged
merged 12 commits into from
Dec 1, 2023

Conversation

srimanachanta
Copy link
Contributor

closes #5062

@srimanachanta srimanachanta requested a review from a team as a code owner February 5, 2023 22:09
wpilibc/src/main/native/include/frc/util/Color.h Outdated Show resolved Hide resolved
wpilibc/src/main/native/include/frc/util/Color.h Outdated Show resolved Hide resolved
wpilibc/src/main/native/include/frc/util/Color.h Outdated Show resolved Hide resolved
@calcmogul
Copy link
Member

This needs unit tests, but I can't find any preexisting ones (which is concerning).

@srimanachanta
Copy link
Contributor Author

/format

@calcmogul calcmogul changed the title Add option to create a Color object from a Hex String Add hex string constructor to Color and Color8Bit Dec 1, 2023
@calcmogul calcmogul changed the title Add hex string constructor to Color and Color8Bit [wpilib] Add hex string constructor to Color and Color8Bit Dec 1, 2023
@PeterJohnson PeterJohnson merged commit 7ed900a into wpilibsuite:main Dec 1, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Color and Color8bit object from a hex string
3 participants