Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Move triggers to subsystem fields #6318

Merged
merged 8 commits into from
Jan 28, 2024

Conversation

DeltaDizzy
Copy link
Contributor

This eases inter-subsystem communication by making it easier to hook command and triggers together regardless of location and also makes code much cleaner and more readable.

@DeltaDizzy DeltaDizzy requested review from a team as code owners January 26, 2024 21:00
@DeltaDizzy
Copy link
Contributor Author

/format

Oblarg
Oblarg previously approved these changes Jan 26, 2024
Oblarg
Oblarg previously approved these changes Jan 26, 2024
Copy link
Member

@Starlight220 Starlight220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Address the formatter failure.
  2. I'm pretty sure that Triggers can be polled directly for the value; in that case there's no point in exposing a getter in addition to a trigger object.

Copy link
Member

@Starlight220 Starlight220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(meant to mark the previous as requesting changes)

@PeterJohnson PeterJohnson merged commit 53ebb66 into wpilibsuite:main Jan 28, 2024
25 checks passed
@DeltaDizzy DeltaDizzy deleted the example-subsystem-triggers branch January 28, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants