-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Move triggers to subsystem fields #6318
Merged
PeterJohnson
merged 8 commits into
wpilibsuite:main
from
DeltaDizzy:example-subsystem-triggers
Jan 28, 2024
Merged
[examples] Move triggers to subsystem fields #6318
PeterJohnson
merged 8 commits into
wpilibsuite:main
from
DeltaDizzy:example-subsystem-triggers
Jan 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/format |
Oblarg
previously approved these changes
Jan 26, 2024
Oblarg
previously approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Address the formatter failure.
- I'm pretty sure that
Trigger
s can be polled directly for the value; in that case there's no point in exposing a getter in addition to a trigger object.
wpilibcExamples/src/main/cpp/examples/RapidReactCommandBot/cpp/RapidReactCommandBot.cpp
Show resolved
Hide resolved
Starlight220
requested changes
Jan 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(meant to mark the previous as requesting changes)
Oblarg
approved these changes
Jan 27, 2024
Starlight220
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eases inter-subsystem communication by making it easier to hook command and triggers together regardless of location and also makes code much cleaner and more readable.