Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Const-qualify SendableChooser.GetSelected() #6356

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Const-qualify SendableChooser.GetSelected() #6356

merged 1 commit into from
Feb 10, 2024

Conversation

KangarooKoala
Copy link
Contributor

No description provided.

@KangarooKoala KangarooKoala requested a review from a team as a code owner February 10, 2024 04:43
@Starlight220
Copy link
Member

Is there any case where the default ctor (or similar) won't be const?

@PeterJohnson
Copy link
Member

Const-ness of the default constructor does not matter.

@PeterJohnson PeterJohnson merged commit e506e09 into wpilibsuite:main Feb 10, 2024
25 checks passed
@KangarooKoala KangarooKoala deleted the sendable-chooser-const-get-selected branch February 10, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KangarooKoala @Starlight220 @PeterJohnson