-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wpiutil] Remove RuntimeDetector and greatly simplify RuntimeLoader #6600
Conversation
We can just use System.loadLibrary() where the old calls were. CombinedRuntimeLoader will not work for loading individual libraries. RuntimeLoader.loadLibrary() might need to stay to give a better error message, but it'd be much simpler then what was already there. |
df7aa18
to
e2a3bdf
Compare
Based off debugging my typo in the AprilTagJNI I'd say the error message isn't that bad but they could be worse in different cases idk |
00449e4
to
503e5c1
Compare
Isn't the error message for raw loadLibrary() just "can't load native library"? I believe the reason we had the more descriptive error was for the (fairly common) case when users didn't have an updated MSVC runtime library installed. |
Yes the error message is just can't load library name here if the updated MSVC runtime is an issue I can add back a simpler version of RuntimeLoader.loadLibrary() |
Let’s do that, yes. |
503e5c1
to
3924e1e
Compare
1bb4783
to
cc64845
Compare
cc64845
to
0572752
Compare
Do any vendor libraries use the removed functionality? |
I don't think so. They shouldn't be doing so anyway if they are. |
Resolves #6598