[cmd] Undeprecate deferredProxy #7417
Open
+16
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
spacey-sooty
commented
Nov 21, 2024
wpilibNewCommands/src/main/native/cpp/frc2/command/Commands.cpp
Outdated
Show resolved
Hide resolved
Not applicable to Python. |
spacey-sooty
force-pushed
the
undeprecate-defferred-proxy
branch
2 times, most recently
from
4380b8a to
7e8be3e
Compare
This changes the way deferred proxy is implemented to not use the deprecated ProxyCommand constructor. This function serves a good purpose that should be kept IMO. The constructor was confusing but this is just good syntactic sugar over `defer(() -> supplier.get().asProxy())`. Signed-off-by: Jade Turner <spacey-sooty@proton.me>
spacey-sooty
force-pushed
the
undeprecate-defferred-proxy
branch
from
7e8be3e to
4123210
Compare
github-actions
bot
added
the
component: command-based
Starlight220
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way deferred proxy is implemented to not use the deprecated ProxyCommand constructor.
This function serves a good purpose that should be kept IMO. The constructor was confusing but this is just good syntactic sugar over
defer(() -> supplier.get().asProxy()).