Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a measure's symbol to its name when logged by Epilogue #7535

Merged
merged 3 commits into from
Dec 22, 2024
Merged

Add a measure's symbol to its name when logged by Epilogue #7535

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e507e8
This does work
WispySparks Dec 10, 2024
c929fba
Actually use the base unit symbol
WispySparks Dec 13, 2024
9bb341b
be dryer
WispySparks Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions epilogue-runtime/src/main/java/edu/wpi/first/epilogue/logging/EpilogueBackend.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,10 @@ default <S> void log(String identifier, Collection<S> value, Struct<S> struct) {
*
* @param identifier the identifier of the data field
* @param value the new value of the data field
* @param <U> the dimension of the unit
*/
default void log(String identifier, Measure<?> value) {
log(identifier, value.baseUnitMagnitude());
default <U extends Unit> void log(String identifier, Measure<U> value) {
log(identifier, value, value.baseUnit());
}

/**
Expand All @@ -212,7 +213,7 @@ default void log(String identifier, Measure<?> value) {
* @param <U> the dimension of the unit
*/
default <U extends Unit> void log(String identifier, Measure<U> value, U unit) {
log(identifier, value.in(unit));
log(identifier + " (" + unit.symbol() + ")", value.in(unit));
}

/**
Expand Down
Loading