Add missing dependency for hailcast diagnostics #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TYPE: bug fix KEYWORDS: hailcast, dependency SOURCE: internal DESCRIPTION OF CHANGES: The PR for hailcast diagnostics (#86), did not include a set of dependencies for the new module, nor did it list the new module as a necessary file for the diagnostics driver. LIST OF MODIFIED FILES: M main/depend.common TESTS CONDUCTED: 1. Code builds with setenv J "-j 1" ... and it did not previously.
|
Already included with PR #126 |
Merged
This was referenced Jul 6, 2020
Closed
This was referenced Sep 15, 2020
Closed
Merged
Closed
This was referenced Dec 23, 2020
Closed
This was referenced Jan 15, 2021
weiwangncar
pushed a commit
that referenced
this pull request
Aug 2, 2022
WRFv4.4 crashes upon LSM initialization when NLCD40 landuse dataset is used because of the VEGPARM tables settings. TYPE: bug fix KEYWORDS: VEGPARM.TBL, NLCD40, LCZ_1, NUDAP SOURCE: Robert Gilliam, US EPA DESCRIPTION OF CHANGES: Problem: WRFv4.4 crashes when reading the VEGPARM.TBL file because of the the LCZ_* specs at the end of the main NLCD40 table entries. Solution: We just copied the values used for MODIS since the NLCD40 is a blend of US NLCD and MODIS. ISSUE: For use when this PR closes an issue. Fixes #123 LIST OF MODIFIED FILES: VEGPARM.TBL TESTS CONDUCTED: Does the mode fix the problem: Yes. We ran a full 2018 simulation at 12 km CONUS and 108 km N. Hemisphere scales and verified this works. The Jenkins tests have passed. RELEASE NOTE: VEGPARM.TBL updated for NLCD40 landuse case to work with recent updates of the LSM initialization that reads the file.
Merged
Merged
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
WRFv4.4 crashes upon LSM initialization when NLCD40 landuse dataset is used because of the VEGPARM tables settings. TYPE: bug fix KEYWORDS: VEGPARM.TBL, NLCD40, LCZ_1, NUDAP SOURCE: Robert Gilliam, US EPA DESCRIPTION OF CHANGES: Problem: WRFv4.4 crashes when reading the VEGPARM.TBL file because of the the LCZ_* specs at the end of the main NLCD40 table entries. Solution: We just copied the values used for MODIS since the NLCD40 is a blend of US NLCD and MODIS. ISSUE: For use when this PR closes an issue. Fixes wrf-model#123 LIST OF MODIFIED FILES: VEGPARM.TBL TESTS CONDUCTED: Does the mode fix the problem: Yes. We ran a full 2018 simulation at 12 km CONUS and 108 km N. Hemisphere scales and verified this works. The Jenkins tests have passed. RELEASE NOTE: VEGPARM.TBL updated for NLCD40 landuse case to work with recent updates of the LSM initialization that reads the file.
Open
Merged
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: hailcast, dependency
SOURCE: internal
DESCRIPTION OF CHANGES:
The PR for hailcast diagnostics (#86), did not include a set of dependencies for the new module, nor did it list the new module as a necessary file for the diagnostics driver.
LIST OF MODIFIED FILES:
M main/depend.common
TESTS CONDUCTED:
setenv J "-j 1"
... and it did not previously.