Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add baton 2.1.0 Singularity image built for iRODS 4.2.7 #12

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Add baton 2.1.0 Singularity image built for iRODS 4.2.7 #12

merged 1 commit into from
Apr 14, 2021

Conversation

kjsanger
Copy link
Member

@kjsanger kjsanger commented Mar 9, 2021

Builds baton in a Singularity container. We are likely to need this given the difficulty of packaging iRODS clients with Conda.

@kjsanger kjsanger requested review from jmtcsngr, mgcam and mksanger March 9, 2021 15:32
@kjsanger kjsanger added the enhancement New feature or request label Mar 9, 2021
@kjsanger kjsanger requested a review from dkj March 10, 2021 12:44
mksanger
mksanger approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@mksanger mksanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built then tested using irods docker images. No problems found.

dkj
dkj approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@dkj dkj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and basic test against prod iRODS

@kjsanger kjsanger mentioned this pull request Apr 13, 2021
Open
@kjsanger kjsanger merged commit 590dde1 into wtsi-npg:devel Apr 14, 2021
@kjsanger kjsanger deleted the feature/baton-2.1.0-singularity branch April 14, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkj dkj dkj approved these changes

@mksanger mksanger mksanger approved these changes

@jmtcsngr jmtcsngr Awaiting requested review from jmtcsngr

@mgcam mgcam Awaiting requested review from mgcam

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjsanger @dkj @mksanger