[NewFeature]列医院信息+按关键字搜索医院 #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menbotics
bot
added
the
kind/feature
|
希望能够将此搜索功能整合进/hospitals接口中，在其添加上可选的searchString参数，作为keyword。 该接口的pr：#38 |
rexwangcc
reviewed
Jan 28, 2020
| @@ -17,6 +17,15 @@ | |||
| 'factory_capacity', | |||
| 'factory_contact', | |||
| ] | |||
| HOSPICAL_HEADERS = [ | |||
| @@ -61,15 +86,33 @@ def hospital_list(): | |||
| 'msg': '', | |||
| } | |||
| try: | |||
| resp_data = csv_helper(HOSPITAL_PATH,HOTEL_HEADERS) | |||
| resp_data = csv_helper(HOSPITAL_PATH,HOSPICAL_HEADERS) | |||
| if keyword.lower() not in field_val_concat: | ||
| is_valid = False | ||
| break | ||
| except Exception as ex: |
There was a problem hiding this comment.
It will be great to not catch all exceptions, but only a handful of expected errors.
| search_result = filter_entity(hospital_all, search_fields, keyword) | ||
| resp['success'] = True | ||
| resp['data'] = search_result | ||
| except Exception as e: |
There was a problem hiding this comment.
Similar to https://github.com/wuhan2020/api-server/pull/38/files#r372081013, this is trying to catch any exceptions, it also swallows the status codes.
rexwangcc
reviewed
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature:
API: http://127.0.0.1:9000/wuhan2020/hospital_search?keyword=${kw}
e.g. http://127.0.0.1:9000/wuhan2020/hospital_search?keyword=%E6%89%8B%E6%9C%AF%E8%A1%A3
返回需要手术衣的医院名单
e.g. http://127.0.0.1:9000/wuhan2020/hospital_search?keyword=%E6%89%8B%E6%9C%AF%E8%A1%A3%20%E4%BB%99%E6%A1%83
返回需要手术衣的仙桃的医院名单
bugfix: